Skip to content

docs: small fix, grammar and readability improvement in globals.rst #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 16, 2018
Merged

docs: small fix, grammar and readability improvement in globals.rst #504

merged 4 commits into from
Jul 16, 2018

Conversation

DennisTraub
Copy link

@DennisTraub DennisTraub commented Jul 9, 2018 •
edited
Loading

Issue #251

Description of changes:

  • Fixed outdated reference to supported resources
  • Improved grammar and readability in Maps section
  • Improved grammar and readability in Lists section

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brettstack brettstack changed the base branch from master to develop July 9, 2018 22:58
@brettstack brettstack changed the title Small fix, grammar and readability improvement in globals.rst docs: small fix, grammar and readability improvement in globals.rst Jul 9, 2018
brettstack
brettstack suggested changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@brettstack brettstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor request and then we're good to go. Thanks!

docs/globals.rst Outdated
.. code:: json
{
STAGE: Production,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you wrap these in double quotes for JSON?

Copy link
Author

@DennisTraub DennisTraub Jul 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done

brettstack
brettstack approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@brettstack brettstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

dhruvsood
dhruvsood approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@dhruvsood dhruvsood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for your contribution, @DennisTraub!

@brettstack brettstack merged commit 8c837b0 into aws:develop Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@brettstack brettstack brettstack approved these changes

@dhruvsood dhruvsood dhruvsood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DennisTraub @brettstack @dhruvsood