Skip to content

Conversation

brettstack
Copy link
Contributor

This makes DefinitionBody and DefinitionUri optional, and if not provided then the API will use the Swagger generated by SAM. This makes it easy for users who rely on Implicit API to use the existing Cors feature and upcoming Authorizers feature by defining an explicit API resource without needing to redefine their entire Swagger

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This makes DefinitionBody and DefinitionUri optional, and if not provided then the API will use the Swagger generated by SAM. This makes it easy for users who rely on Implicit API to use the existing Cors feature and upcoming Authorizers feature by defining an explicit API resource without needing to redefine their entire Swagger
Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! There are just a few small changes I've requested and some questions to answer in the code.

@brettstack brettstack requested a review from jlhood August 8, 2018 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants