Minor grammatical corrections #482
Conversation
A couple of minor grammatical corrections I noticed while reading the page.
|
|
||
| The [AWS SAM CLI](https://github.com/awslabs/aws-sam-cli) builds on top of the SAM specification by providing a single tool to manage the packaging and deployment of serverless applications. Once the `sam` tool is installed, the application deployment process occurs in two phases. | ||
|
|
||
| First, use `sam` to upload the binary to S3 and reference it in a newly created `packaged.yaml` CloudFormation configuration. |
| $ diff template.yaml packaged.yaml | ||
| ``` | ||
|
|
||
| Lastly, use `sam` again to deploy the template through a CloudFormation stack named `Test`. |
There was a problem hiding this comment.
Change "Lastly, use sam again" to "Second, use sam package..."
|
|
||
| ### Deployment | ||
|
|
||
| The [AWS SAM CLI](https://github.com/awslabs/aws-sam-cli) builds on top of the SAM specification by providing a single tool to manage the packaging and deployment of serverless applications. Once the `sam` tool is installed, the application deployment process occurs in two phases. |
There was a problem hiding this comment.
Please change this to:
The AWS SAM CLI lets you locally build, test, and debug serverless applications defined by AWS SAM templates. You can also use ‘sam cli’ to deploy your application. Install sam cli, and then deploy your application in two steps:
There was a problem hiding this comment.
Thanks for doing this, @andrew-dixon. I've added a couple of minor comments.
|
@andrew-dixon I merged develop in as there was a conflict from another PR I just merged into develop. Could you take a look at the comments from @sooddhruv and we'll get this merged in. Thanks! |
|
@brettstack Not sure if I'm missing something but I don't see any comments and the things above that say "outdated" are to a different file anyway. |
|
@andrew-dixon yeah, those comments were for examples/2016-10-31/schedule/README.md. I've submitted a PR to address those. Your changes to HOWTO.md look good. Thank you for your contribution! |
3 participants
A couple of minor grammatical corrections I noticed while reading the page.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.