Skip to content

Conversation

glnds
Copy link
Contributor

@glnds glnds commented Jul 5, 2018

Currently CodeUri on Globals is not yet supported by CloudFormation package.

Issue #, if available: As i was unaware of this it took me quite a while to figure this out...

Description of changes: Added just as simple comment to point out the fact the property is not yet supported by CloudFormation package.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Currently CodeUri on Globals is not yet supported by CloudFormation package.
@brettstack brettstack changed the base branch from master to develop July 11, 2018 04:48
@brettstack
Copy link
Contributor

Makes sense since package is run pre-transformation. Might be a feature request for when SAM CLI implements its own package command @jfuss @sanathkr

Copy link
Contributor

@dhruvsood dhruvsood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks, @glnds!

@brettstack brettstack merged commit 355c26b into aws:develop Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants