TBDGen: Refactor symbol enumeration into SIL and IRGen utilities #61685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
force-pushed
the
refactor-tbdgen-visitor
branch
4 times, most recently
from
438e1ab to
860de29
Compare
tshortli
changed the title
|
@swift-ci please smoke test |
nkcsgexi
approved these changes
Oct 24, 2022
tshortli
force-pushed
the
refactor-tbdgen-visitor
branch
2 times, most recently
from
fa73442 to
45f5963
Compare
|
@swift-ci please test |
tshortli
force-pushed
the
refactor-tbdgen-visitor
branch
3 times, most recently
from
4a7d42c to
38adf3f
Compare
tshortli
force-pushed
the
refactor-tbdgen-visitor
branch
from
38adf3f to
cbc4890
Compare
…SILSymbolVisitor` and `IRSymbolVisitor`.
tshortli
force-pushed
the
refactor-tbdgen-visitor
branch
from
cbc4890 to
fc20262
Compare
|
@swift-ci please smoke test and merge |
|
🎉 |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBDGen enumerates all the symbols in a file or module and emits a list of linkable symbols that will be present in the resulting library binary. SILGen and IRGen for
if #_hasSymbol(...)have similar requirements; given a declaration, we need to enumerate each of the public symbols associated with that declaration to emit a runtime check for that symbol.Given the overlap in requirements, I have factored the core logic of
TBDGenVisitorinto a couple of new visitor classes located inlibswiftSILandlibswiftIRGenand then reimplementedTBDGenVisitoron top of the new abstractions. The newSILSymbolVisitorclass is responsible for the core enumeration of linkable entities. Entities that can be represented as aSILDeclRefare enumerated as such, but many other entities do not have a conceptual representation at the SIL layer. The responsibility of representing these is delegated toIRSymbolVisitorwhich turns entities intoLinkEntityinstances where possible. Finally, a small number of remaining entities cannot be represented byLinkEntityand are passed through directly.For the moment, I've tried to reduce the risk of this change by preserving the behavior of
TBDGenVisitoras much as possible in the new factoring. In the future, though, it's possible that there could be further refactoring and simplification. For instance, some features like Swift API extraction and symbol source map generation could be implemented directly on top ofIRSymbolVisitorinstead of being mixed into the responsibilities ofTBDGenVisitor. As much as possible, I'd also like to close the gaps where linkable entities cannot be represented bySILDeclReforLinkEntity.