IDE: Break CMake cycle involving IDE, FrontendTool, Frontend, and Migrator #61774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rintaro I don't love the name |
tshortli
force-pushed
the
break-ide-frontend-cmake-cycle
branch
from
b7aecf2 to
d4413cf
Compare
…rator. These libraries formed a strongly connected component in the CMake build graph. The weakest link I could find was from IDE to FrontendTool and Frontend, which was necessitated by the `CompileInstance` class (swiftlang#40645). I moved a few files out of IDE into a new IDETools library to break the cycle.
tshortli
force-pushed
the
break-ide-frontend-cmake-cycle
branch
from
d4413cf to
58d82f0
Compare
|
@swift-ci please smoke test |
rintaro
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDE, FrontendTool, Frontend, and Migrator libraries formed a strongly connected component in the CMake build graph. The weakest link I could find was from IDE to FrontendTool and Frontend, which was necessitated by the
CompileInstanceclass (#40645). I moved a few files out of IDE into a new library to break the cycle.