Skip to content

Move 'ConstExtract' request from TypeCheckRequest into its own component's collection of requests. #61792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Oct 28, 2022

This helps make sure that components that do not genuinely do not depend on libSwiftConstExtract do not need to actually have a dependency edge to it.

@artemcm
Copy link
Contributor Author

artemcm commented Oct 28, 2022

@swift-ci test

Copy link
Contributor

@tshortli tshortli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for hopping on this!

@artemcm artemcm force-pushed the MoveConstRequestOutOfAST branch from fac0908 to 45e4278 Compare October 28, 2022 19:45
@artemcm
Copy link
Contributor Author

artemcm commented Oct 28, 2022

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Oct 28, 2022

@swift-ci test

@artemcm artemcm force-pushed the MoveConstRequestOutOfAST branch from 45e4278 to 71157c7 Compare October 28, 2022 20:51
@artemcm artemcm force-pushed the MoveConstRequestOutOfAST branch from 71157c7 to 5a38d65 Compare October 28, 2022 20:55
@artemcm
Copy link
Contributor Author

artemcm commented Oct 28, 2022

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Oct 28, 2022

@swift-ci test macOS platform

@tshortli
Copy link
Contributor

@swift-ci test Linux

@tshortli tshortli merged commit 27198ac into swiftlang:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants