Skip to content

SILOptimizer: Break circular dependency with SIL library by moving canDuplicate() #61779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

tshortli
Copy link
Contributor

Fixes a cycle introduced by #61051.

@tshortli tshortli requested a review from meg-gupta October 27, 2022 23:13
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tshortli
Copy link
Contributor Author

@swift-ci please smoke test macOS

@tshortli tshortli merged commit cfb5ad8 into swiftlang:main Oct 28, 2022
@tshortli tshortli deleted the break-cycle-loop-can-duplicate branch October 28, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants