Serialization: Break the cycle between Serialization and SymbolGraphGen #61784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
changed the title
xymus
approved these changes
Oct 28, 2022
artemcm
approved these changes
Oct 28, 2022
nkcsgexi
approved these changes
Oct 28, 2022
tshortli
force-pushed
the
break-cycle-serialization-symbolgen
branch
from
e4e77fb to
6fe4813
Compare
|
This depends on #61792 since this PR removes the last circular dependency that was bringing in |
tshortli
force-pushed
the
break-cycle-serialization-symbolgen
branch
3 times, most recently
from
9fa11da to
1cb0d1f
Compare
Push the top level logic for writing out swiftmodules and associated files into the frontend library which has access to all the necessary dependencies.
tshortli
force-pushed
the
break-cycle-serialization-symbolgen
branch
from
1cb0d1f to
af032af
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push the top level logic for writing out swiftmodules and associated files into the frontend library which has access to all the necessary dependencies.
Fixes the circular dependency between Serialization and SymbolGraphGen that was introduced with #35110.