Skip to content

APIDigester: Break cycle between Frontend and APIDigester targets #61758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Oct 27, 2022

Also push a utility that was previously on SILDeclRef down to AST so that the SIL dependency can be removed entirely from APIDigester.

Also push a utility that was previously on `SILDeclRef` down to AST so that the SIL dependency can be removed entirely from APIDigester.
@tshortli tshortli changed the title APIDigester: Break cycle between swiftFrontend and swiftAPIDigester APIDigester: Break cycle between Frontend and APIDigester targets Oct 27, 2022
@tshortli tshortli force-pushed the break-frontend-apidigester-cmake-cycle branch from e71cd5c to 0d37f52 Compare October 27, 2022 03:33
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli tshortli marked this pull request as ready for review October 27, 2022 03:34
@tshortli tshortli requested review from etcwilde and nkcsgexi October 27, 2022 03:34
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tshortli tshortli merged commit f32ae6f into swiftlang:main Oct 27, 2022
@tshortli tshortli deleted the break-frontend-apidigester-cmake-cycle branch October 27, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants