test: First draft for settings wrappers and test file added #6984
+844
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (81)
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6984 +/- ##
========================================
Coverage 59.61% 59.61%
========================================
Files 820 820
Lines 115759 115774 +15
========================================
+ Hits 69010 69022 +12
+ Misses 39691 39650 -41
- Partials 7058 7102 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AYAHASSAN287
changed the title
AYAHASSAN287
force-pushed
the
test/settings-tests
branch
from
e1ee154 to
c6ec2c2
Compare
…nce and transferdetector
- Sets MOBILE_GOARCH to amd64 when ARCH is x86_64 - Sets ANDROID_CLANG_TARGET to x86_64-linux-android<API>
Referenced issue: * status-im/infra-ci#188
* test: community chats * test: community chats review
* chore: upgrade go-waku and go-discover * chore: make vendor * feat: go-waku v0.10.0
- Use sqlite.Migrate in protocol to remove logic duplication. - Remove legacy ad-hoc migration fix. It is now safe to assume that no users are running versions old enough to require this workaround.
These utils are generic enough to be moved to crypto package.
Not sure if this will only hide the root cause because the proper flow on pairing is unknown to me. But from what I've seen Waku is only started after login. While `subscribe` and `unsubscribe` is used in the pairing flow as well.
* feat: improvemets to multistandardbalance controller * feat: introduce tokenbalances package * chore: replace balance fetching capabilities from reader and token manager with tokenbalances * feat: allow overriding multicall3 contract address * chore: fix tests * chore: pr comments
* fix: goimports only 1 local package * fix: vscode settings goimports * fix: un-gitignore IDEA code styles * feat: goland code styles * fix: remove generate_handlers nolint comment * chore: lint-fix all files
* feat: local timesource * fix: nwaku * fix: rebase issues
* feat: added numThreads to expvars * test: added num of threads and goroutines to benchmarks * fix: issues
* chore: make rpc.Client implement EthClientGetter * chore: remove unused types * chore: cleanup unused methods and use interface instead of rpc Client * chore: cleanup transactor * chore: move pendingtxtracker to separate package * chore: fix tests
AYAHASSAN287
force-pushed
the
test/settings-tests
branch
from
c6ec2c2 to
fcd6bc2
Compare
fbarbu15
reviewed
Oct 20, 2025
| type NotificationsSettings struct { | ||
| db *sql.DB | ||
| } | ||
| type ExemptionsDefaults struct { |
There was a problem hiding this comment.
what's with the changes in the .go files?
| add_resp = self.account.accounts_service.add_keypair_via_seed_phrase( | ||
| user_1.passphrase, self.account.password, keypair_name, wallet_account_details_derivation | ||
| ) | ||
| self.account.accounts_service.migrate_non_profile_keycard_keypair_to_app |
| return response.content.decode("utf-8") | ||
|
|
||
| def get_boot_api_config(self): | ||
| return copy.deepcopy(self._boot_api_config) |
There was a problem hiding this comment.
you already did a deepcopy at line 295 / 303
| def test_news_feed_enabled(self): | ||
| result = self.config.settings_service.news_feed_enabled() | ||
| assert isinstance(result, bool), f"Expected boolean, got {type(result)}" | ||
| print(f"News feed enabled: {result}") |
There was a problem hiding this comment.
we don't use prints, but logger
please update everywhere
There was a problem hiding this comment.
anyhow I don't see the purpose of the print/log here
please remove then if they were just for debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds full Python wrappers for all Settings RPC endpoints and introduces an extensive functional test suite that validates:
Scope (new coverage)
Wrappers (settings.py)
Added wrappers for all Settings APIs, including:
Base / Node / Backup / News APIs (get_settings, save_setting, get_node_config, backup_path, messages_backup_enabled, news_*).
Tests (test_settings.py)
Added full functional coverage validating:
Known Issues / Follow-ups