chore: cleanup chain client and transactor #7008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (37)
|
dlipicar
force-pushed
the
chore/cleanup-chain-client
branch
from
ec70240 to
c596737
Compare
dlipicar
changed the title
dlipicar
force-pushed
the
chore/cleanup-chain-client
branch
from
c596737 to
29c0ba6
Compare
dlipicar
force-pushed
the
chore/cleanup-chain-client
branch
from
29c0ba6 to
6724214
Compare
alaibe
approved these changes
Oct 16, 2025
dlipicar
force-pushed
the
chore/cleanup-chain-client
branch
2 times, most recently
from
c0b1a2a to
fb6ec5a
Compare
dlipicar
force-pushed
the
chore/cleanup-chain-client
branch
from
fb6ec5a to
0325ff1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7008 +/- ##
===========================================
+ Coverage 54.99% 59.37% +4.37%
===========================================
Files 823 820 -3
Lines 116510 115759 -751
===========================================
+ Hits 64077 68729 +4652
+ Misses 45649 39940 -5709
- Partials 6784 7090 +306
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AYAHASSAN287
pushed a commit
that referenced
this pull request
Oct 20, 2025
* chore: make rpc.Client implement EthClientGetter * chore: remove unused types * chore: cleanup unused methods and use interface instead of rpc Client * chore: cleanup transactor * chore: move pendingtxtracker to separate package * chore: fix tests
AYAHASSAN287
pushed a commit
that referenced
this pull request
Oct 20, 2025
* chore: make rpc.Client implement EthClientGetter * chore: remove unused types * chore: cleanup unused methods and use interface instead of rpc Client * chore: cleanup transactor * chore: move pendingtxtracker to separate package * chore: fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
balancepackage, not used anymore.TODO: Basicallyh every method from
transactorthat is exposed through direct C-bindings should instead be exposed through theconnectorservice. Only WalletConnect is using it status-desktop side.