Skip to content

Conversation

@igor-sirotin
Copy link
Collaborator

Added these metrics to benchmarks, as needed for status-im/status-desktop#18995

  • Number of goroutines
  • Number of threads

@status-im-auto
Copy link
Member

status-im-auto commented Oct 15, 2025

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5893d5d #1 2025-10-15 16:32:37 ~4 min linux/status-go 📦zip
✔️ 5893d5d #1 2025-10-15 16:34:03 ~5 min windows/status-go 📦zip
✖️ 5893d5d #1 2025-10-15 16:34:40 ~6 min tests-rpc 📄log
✔️ 5893d5d #1 2025-10-15 16:39:50 ~11 min linux/nwaku 📦zip
5893d5d #1 2025-10-15 16:40:15 ~11 min macos/status-go 📄log
✔️ 5893d5d #1 2025-10-15 16:59:19 ~30 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3c6cfb4 #2 2025-10-16 16:13:01 ~5 min linux/status-go 📦zip
✔️ 3c6cfb4 #2 2025-10-16 16:13:30 ~5 min windows/status-go 📦zip
✖️ 3c6cfb4 #2 2025-10-16 16:14:19 ~6 min tests-rpc 📄log
✔️ 3c6cfb4 #2 2025-10-16 16:22:02 ~14 min linux/nwaku 📦zip
✔️ 3c6cfb4 #2 2025-10-16 16:25:38 ~18 min macos/status-go 📦zip
✔️ 3c6cfb4 #2 2025-10-16 16:39:02 ~31 min tests 📄log
✔️ f136de9 #3 2025-10-16 16:36:22 ~3 min macos/status-go 📦zip
✔️ f136de9 #3 2025-10-16 16:36:40 ~3 min linux/status-go 📦zip
✔️ f136de9 #3 2025-10-16 16:38:47 ~5 min windows/status-go 📦zip
✔️ f136de9 #3 2025-10-16 16:44:27 ~11 min linux/nwaku 📦zip
✔️ f136de9 #3 2025-10-16 16:44:30 ~11 min tests-rpc 📄log
✔️ f136de9 #3 2025-10-16 17:06:08 ~26 min tests 📄log

Copy link
Contributor

@osmaczko osmaczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@igor-sirotin igor-sirotin force-pushed the feat/benchmarks-threads-goroutines-count branch from 5893d5d to 3c6cfb4 Compare October 16, 2025 16:07
@igor-sirotin igor-sirotin force-pushed the feat/benchmarks-threads-goroutines-count branch from 3c6cfb4 to f136de9 Compare October 16, 2025 16:32
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.33%. Comparing base (ca11baf) to head (f136de9).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
cmd/status-backend/server/server.go 20.00% 3 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (20.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7006      +/-   ##
===========================================
+ Coverage    55.00%   59.33%   +4.32%     
===========================================
  Files          821      822       +1     
  Lines       116496   116503       +7     
===========================================
+ Hits         64083    69129    +5046     
+ Misses       45645    40255    -5390     
- Partials      6768     7119     +351     
Flag Coverage Δ
functional 35.09% <20.00%> (?)
unit 54.98% <20.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/status-backend/server/server.go 65.29% <20.00%> (+7.71%) ⬆️

... and 210 files with indirect coverage changes

@igor-sirotin igor-sirotin merged commit b65e462 into develop Oct 16, 2025
20 of 21 checks passed
@igor-sirotin igor-sirotin deleted the feat/benchmarks-threads-goroutines-count branch October 16, 2025 17:13
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Oct 16, 2025
AYAHASSAN287 pushed a commit that referenced this pull request Oct 20, 2025
* feat: added numThreads to expvars

* test: added num of threads and goroutines to benchmarks

* fix: issues
AYAHASSAN287 pushed a commit that referenced this pull request Oct 20, 2025
* feat: added numThreads to expvars

* test: added num of threads and goroutines to benchmarks

* fix: issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants