Skip to content

Conversation

@igor-sirotin
Copy link
Collaborator

@igor-sirotin igor-sirotin commented Oct 14, 2025

Description

  1. Use timesource.Provider and timesource.Service interfaces
  2. Implemented a local timesource service (will be used in privacy mode)
  3. Moved timesource package to internal/timesource, refactored things a bit

@status-im-auto
Copy link
Member

status-im-auto commented Oct 14, 2025

Jenkins Builds

Click to see older builds (6)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6b20dc3 #1 2025-10-14 12:35:26 ~3 min macos/status-go 📦zip
✔️ 6b20dc3 #1 2025-10-14 12:35:42 ~3 min linux/status-go 📦zip
✔️ 6b20dc3 #1 2025-10-14 12:38:13 ~6 min windows/status-go 📦zip
6b20dc3 #1 2025-10-14 12:41:06 ~9 min linux/nwaku 📄log
✔️ 6b20dc3 #1 2025-10-14 12:43:52 ~11 min tests-rpc 📄log
✔️ 6b20dc3 #1 2025-10-14 12:59:16 ~27 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5930559 #2 2025-10-14 12:54:07 ~4 min linux/status-go 📦zip
✔️ 5930559 #2 2025-10-14 12:54:12 ~4 min macos/status-go 📦zip
✔️ 5930559 #2 2025-10-14 12:56:24 ~6 min windows/status-go 📦zip
✔️ 5930559 #2 2025-10-14 13:02:20 ~12 min linux/nwaku 📦zip
✔️ 5930559 #2 2025-10-14 13:05:36 ~15 min tests-rpc 📄log
✔️ 5930559 #2 2025-10-14 13:27:41 ~28 min tests 📄log
✔️ 7caf19e #3 2025-10-16 16:08:44 ~4 min linux/status-go 📦zip
✔️ 7caf19e #3 2025-10-16 16:10:33 ~5 min windows/status-go 📦zip
✔️ 7caf19e #3 2025-10-16 16:18:49 ~14 min linux/nwaku 📦zip
✔️ 7caf19e #3 2025-10-16 16:20:30 ~15 min tests-rpc 📄log
✔️ 7caf19e #3 2025-10-16 16:22:01 ~17 min macos/status-go 📦zip
✔️ 7caf19e #3 2025-10-16 16:36:08 ~31 min tests 📄log

@igor-sirotin igor-sirotin self-assigned this Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.45%. Comparing base (ca11baf) to head (7caf19e).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
internal/timesource/local.go 0.00% 6 Missing ⚠️
node/status_node_services.go 50.00% 1 Missing and 2 partials ⚠️
internal/timesource/timesource.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7003      +/-   ##
===========================================
+ Coverage    55.00%   59.45%   +4.44%     
===========================================
  Files          821      824       +3     
  Lines       116496   116509      +13     
===========================================
+ Hits         64083    69265    +5182     
+ Misses       45645    40155    -5490     
- Partials      6768     7089     +321     
Flag Coverage Δ
functional 35.22% <51.72%> (?)
unit 55.00% <58.62%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/push-notification-server/main.go 51.93% <100.00%> (+51.93%) ⬆️
internal/timesource/ntp.go 92.35% <100.00%> (ø)
messaging/core.go 55.26% <ø> (+2.82%) ⬆️
messaging/waku/gowaku.go 65.90% <100.00%> (+4.75%) ⬆️
node/get_status_node.go 68.13% <ø> (+2.71%) ⬆️
protocol/ens/verifier.go 43.38% <100.00%> (ø)
protocol/messenger_settings.go 20.54% <ø> (ø)
server/pairing/client.go 49.35% <ø> (+18.58%) ⬆️
server/pairing/server.go 62.92% <ø> (+16.47%) ⬆️
services/accounts/multiaccounts.go 30.00% <ø> (+27.14%) ⬆️
... and 4 more

... and 208 files with indirect coverage changes

@igor-sirotin igor-sirotin marked this pull request as ready for review October 14, 2025 13:32
@igor-sirotin igor-sirotin force-pushed the feat/no-ntp-timesource branch from 5930559 to 7caf19e Compare October 16, 2025 16:04
@igor-sirotin igor-sirotin merged commit 473e383 into develop Oct 16, 2025
21 checks passed
@igor-sirotin igor-sirotin deleted the feat/no-ntp-timesource branch October 16, 2025 16:36
AYAHASSAN287 pushed a commit that referenced this pull request Oct 20, 2025
* feat: local timesource

* fix: nwaku

* fix: rebase issues
AYAHASSAN287 pushed a commit that referenced this pull request Oct 20, 2025
* feat: local timesource

* fix: nwaku

* fix: rebase issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants