Skip to content

Breaking changes in 1.0 #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 26, 2022
Merged

Breaking changes in 1.0 #496

merged 5 commits into from
Jan 26, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Sep 16, 2021 •
edited
Loading

Description

This PR contains breaking changes and will bump the version number to 1.0:

  • Drop support for react-native 0.60 and 0.61
  • Android:
    • Remove workaround for trove4j
    • Bump minimum Android SDK version to 23
    • Bump Android Gradle Plugin to v7
      • JDK 11 is now required to run Gradle (details)
    • Bump Gradle to v7
    • Use buildToolsVersion set by Gradle
  • iOS/macOS:
    • Bump C++ standard to C++17

Blocked by:

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

CI should be green.

@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS labels Sep 16, 2021
@tido64 tido64 added this to the 1.0 milestone Sep 22, 2021
@tido64 tido64 changed the title Milestone 1.0 Breaking changes in 1.0 Sep 22, 2021
@tido64 tido64 force-pushed the tido/1.0 branch 3 times, most recently from 854e72d to 4067c55 Compare October 22, 2021 12:04
@tido64 tido64 force-pushed the tido/1.0 branch 3 times, most recently from 8ae1602 to 5647584 Compare October 27, 2021 09:04
@tido64 tido64 force-pushed the tido/1.0 branch 5 times, most recently from ca42acc to cbd1431 Compare December 14, 2021 07:17
@tido64 tido64 force-pushed the tido/1.0 branch 6 times, most recently from db24bac to 609572a Compare December 17, 2021 18:54
@tido64 tido64 marked this pull request as ready for review January 4, 2022 14:05
@tido64 tido64 mentioned this pull request Jan 12, 2022
Closed
1 task
@tido64 tido64 force-pushed the tido/1.0 branch 2 times, most recently from 5a506e3 to ac04458 Compare January 19, 2022 10:38
tido64 added 2 commits January 26, 2022 12:48
@tido64
feat: drop support for react-native 0.60 and 0.61
ee08174 
BREAKING CHANGE: react-native 0.60 and 0.61 are no longer supported.
Deprecated methods have also been removed.
@tido64
fix(android): remove workaround for trove4j
a029b3f 
BREAKING CHANGE: `android/force-resolve-trove4j.gradle` has been
removed.

`org.jetbrains.trove4j:trove4j` has been uploaded to Maven Central:
https://search.maven.org/artifact/org.jetbrains.trove4j/trove4j/20160824/jar
@tido64
Copy link
Member Author

tido64 commented Jan 26, 2022

@arazabishov, @kelset, @sweggersen, @tom-un: Please review this whenever you have time. Thanks ❤️

kelset
kelset approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@tido64 tido64 merged commit a6f8601 into trunk Jan 26, 2022
@tido64 tido64 deleted the tido/1.0 branch January 26, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-un tom-un Awaiting requested review from tom-un

@sweggersen sweggersen Awaiting requested review from sweggersen

@arazabishov arazabishov Awaiting requested review from arazabishov

1 more reviewer

@kelset kelset kelset approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @kelset