Skip to content

fix(windows): wildcards in project items are not supported #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2021
Merged

fix(windows): wildcards in project items are not supported #549

merged 3 commits into from
Oct 17, 2021

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 11, 2021 •
edited
Loading

Description

It doesn't look like wildcards are properly supported in Visual Studio. Converted to generating entries for all resources.

Resolves #484.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

  1. Test app should work with dev server: 
    yarn install-windows-test-app --use-nuget
yarn windows
  2. Test app should work with JS bundle, without dev server: 
    # terminate dev server
yarn build:windows
yarn install-windows-test-app --use-nuget
yarn windows

Assets used to be empty before, but should be populated properly now:
Screenshot 2021-10-11 132125

@github-actions github-actions bot added the platform: Windows This affects Windows label Oct 11, 2021
@tido64 tido64 linked an issue Oct 13, 2021 that may be closed by this pull request
Windows: Wildcards in project items are not supported in VC projects #484
Closed
5 tasks
@tido64 tido64 requested a review from afoxman October 13, 2021 19:26
afoxman
afoxman approved these changes Oct 17, 2021
View reviewed changes
Base automatically changed from tido/test-with-memfs to trunk October 17, 2021 07:16
@tido64 tido64 force-pushed the tido/vcxproj-wildcards branch from 061af2a to 68258d2 Compare October 17, 2021 07:17
@tido64 tido64 enabled auto-merge (squash) October 17, 2021 07:28
@tido64 tido64 mentioned this pull request Oct 17, 2021
Merged
31 tasks
github-actions[bot]
github-actions bot reviewed Oct 17, 2021
View reviewed changes
@tido64 @github-actions
add missing semicolon
95b1f16 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@tido64 tido64 added this to the 1.0 milestone Oct 17, 2021
@tido64 tido64 merged commit 8df5b64 into trunk Oct 17, 2021
@tido64 tido64 deleted the tido/vcxproj-wildcards branch October 17, 2021 07:51
@github-actions
Copy link

🎉 This PR is included in version 0.9.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@afoxman afoxman afoxman approved these changes

@sweggersen sweggersen Awaiting requested review from sweggersen

@arazabishov arazabishov Awaiting requested review from arazabishov

@kelset kelset Awaiting requested review from kelset

Assignees

No one assigned

Labels

platform: Windows This affects Windows released

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

Windows: Wildcards in project items are not supported in VC projects

2 participants

@tido64 @afoxman