fix(apple): reduce build noise from Flipper and dependencies #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: iOS
kelset
reviewed
Sep 20, 2021
| LastSwiftUpdateCheck = 1250; | ||
| LastUpgradeCheck = 1250; | ||
| LastSwiftUpdateCheck = 1300; | ||
| LastUpgradeCheck = 1300; |
There was a problem hiding this comment.
probably just a nit, but might be worth waiting for this change to land for when Xcode 13.0 comes out? Or write a note somewhere about the fact that we're already using Xcode 13 here?
Or just do nothing, I guess it's mostly just you using this repo anyway 😅
There was a problem hiding this comment.
These two lines don't really do anything other than letting Xcode know that we've done a code base "upgrade". There were no changes between 12 and 13 in RNTA, so these have no other effect than not prompting users to upgrade when they open a project with Xcode 13.
kelset
approved these changes
Sep 20, 2021
|
🎉 This PR is included in version 0.7.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warnings were disabled for Flipper and its dependencies because there are too many, making it difficult to see real issues.
Platforms affected
Test plan
Green CI.