Skip to content

fix(windows): fix error parsing Hermes engine version #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2021
Merged

fix(windows): fix error parsing Hermes engine version #523

merged 1 commit into from
Sep 23, 2021

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Sep 22, 2021

Description

The Hermes version scheme changed in 0.65, breaking the parser.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

yarn
cd example
yarn install-windows-test-app --use-hermes
yarn windows

@tido64 tido64 requested a review from kelset September 22, 2021 22:22
@tido64 tido64 added this to the 1.0 milestone Sep 22, 2021
@github-actions github-actions bot added the platform: Windows This affects Windows label Sep 22, 2021
@tido64 tido64 mentioned this pull request Sep 22, 2021
Merged
31 tasks
@tido64 tido64 merged commit be0d87d into trunk Sep 23, 2021
@tido64 tido64 deleted the tido/fix-windows-hermes branch September 23, 2021 09:58
@github-actions
Copy link

🎉 This PR is included in version 0.7.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kelset kelset kelset approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform: Windows This affects Windows released

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @kelset