Skip to content

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 18, 2022

Description

Make sure to call __apply_Xcode_12_5_M1_post_install_workaround if it is defined.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

npm run set-react-version canary-macos
yarn
cd example
pod install --project-directory=macos
../scripts/xcodebuild.sh macos/Example.xcworkspace build

# Also make sure iOS builds
pod install --project-directory=ios
../scripts/xcodebuild.sh ios/Example.xcworkspace build

@tido64 tido64 requested review from Saadnajmi, kelset and tom-un January 18, 2022 10:37
@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS labels Jan 18, 2022
const VALID_TAGS = ["canary-macos", "canary-windows", "main", "nightly"];
const REACT_NATIVE_VERSIONS = {
"canary-macos": "^0.64",
"canary-macos": "^0.66",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a simple question for me to learn - here you can put 0.66 already even if it's not out yet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(as far as I can see, the canary macos on npm have the 0.0.0-hash format)

Copy link
Member Author

@tido64 tido64 Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for pointing at the correct version of react-native to install with react-native-macos. The latter doesn't specify which version to use because it is self-contained, but I think cli complains if it cannot find react-native.

@tido64 tido64 merged commit b2b5f92 into trunk Jan 18, 2022
@tido64 tido64 deleted the tido/prep-macos-0.66 branch January 18, 2022 12:32
@tido64 tido64 added this to the 1.0 milestone Jan 26, 2022
@tido64 tido64 mentioned this pull request Jan 26, 2022
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants