Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Feat/top app bar/iss 499 #688

Merged
merged 37 commits into from
Feb 27, 2019

Conversation

mgr34
Copy link
Contributor

@mgr34 mgr34 commented Feb 21, 2019

A Successful merge would close issue #499 and introduce a slew of breaking changes

  • Attempts to create a more declarative syntax for top-app-bar.
  • implements missing foundation methods initScrollHandler and destroyScrollHandler.
  • updates component mdc-top-app-bar to 0.44.0

note: golden.json has not been updated.


I signed it

gugu and others added 26 commits January 30, 2019 10:50
…raction (material-components#653)

BREAKING CHANGE: renamed chip.props.removeIcon --> chips.props.trailingIcon
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

codecov-io commented Feb 21, 2019

Codecov Report

Merging #688 into rc0.11.0 will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           rc0.11.0     #688     +/-   ##
===========================================
+ Coverage     94.88%   94.98%   +0.1%     
===========================================
  Files            68       73      +5     
  Lines          2853     2912     +59     
  Branches        432      444     +12     
===========================================
+ Hits           2707     2766     +59     
  Misses           50       50             
  Partials         96       96
Impacted Files Coverage Δ
packages/top-app-bar/Title.tsx 100% <100%> (ø)
packages/top-app-bar/Icon.tsx 100% <100%> (ø)
packages/top-app-bar/Row.tsx 100% <100%> (ø)
packages/top-app-bar/Section.tsx 100% <100%> (ø)
packages/top-app-bar/constants.ts 100% <100%> (ø)
packages/top-app-bar/index.tsx 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d36b6...409ccea. Read the comment docs.

@mgr34 mgr34 force-pushed the feat/top-app-bar/iss-499 branch from d87229d to 38c0417 Compare February 21, 2019 19:12
Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgr34 this is awesome! Thanks for doing all these changes. This review is my initial pass, and includes all the big ticket items. Test coverage looks good too btw.

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but the rest looks good. Going to fix the screenshot tests. Please look out for those

@moog16
Copy link

moog16 commented Feb 26, 2019

created #694

@moog16
Copy link

moog16 commented Feb 26, 2019

prominentToShortCollapsed: 203d617f5358eaa406fafbb41b3adce69bd4c3939791dbf85738b8e49e93dfa6
shortCollapsed: a711abff27747da6c91a09525a2a17ae889ce1a0ff81d513b0b3b067b66abac3
short: 90dba9623f16d58cfc4a24b2a3ab652c7e0cc6d5ccfd030566a170a55d6bce0c
twoRows: a7c025c8c04123d377f53a3e3e888eb4de78439b9dcd76c306e67712934f9ed1

@moog16
Copy link

moog16 commented Feb 27, 2019

merging! Signed in #688 (comment)

@moog16 moog16 merged commit 84b6395 into material-components:rc0.11.0 Feb 27, 2019
@moog16
Copy link

moog16 commented Feb 27, 2019

created #698 for 0.13.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.