-
Notifications
You must be signed in to change notification settings - Fork 232
Feat/top app bar/iss 499 #688
Feat/top app bar/iss 499 #688
Conversation
…raction (material-components#653) BREAKING CHANGE: renamed chip.props.removeIcon --> chips.props.trailingIcon
…new scrollTarget prop
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## rc0.11.0 #688 +/- ##
===========================================
+ Coverage 94.88% 94.98% +0.1%
===========================================
Files 68 73 +5
Lines 2853 2912 +59
Branches 432 444 +12
===========================================
+ Hits 2707 2766 +59
Misses 50 50
Partials 96 96
Continue to review full report at Codecov.
|
d87229d
to
38c0417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mgr34 this is awesome! Thanks for doing all these changes. This review is my initial pass, and includes all the big ticket items. Test coverage looks good too btw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, but the rest looks good. Going to fix the screenshot tests. Please look out for those
created #694 |
|
merging! Signed in #688 (comment) |
created #698 for 0.13.0 |
A Successful merge would close issue #499 and introduce a slew of breaking changes
initScrollHandler
anddestroyScrollHandler
.I signed it