This repository was archived by the owner on Jan 14, 2025. It is now read-only.
fix(button): Support anchor and button HTML attributes (#679) #680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've chosen to extend
React.AnchorHTMLAttributes<T>
andReact.ButtonHTMLAttributes<T>
since these are the possible element types that can be rendered. However looking through the other components you seem to useHTMLProps<T>
a lot as well. There doesn't seem to be any clear reason why this is used in some places and not in others.I'm happy to change this to use
HTMLProps<T>
instead if that is the pattern you want to follow. It would make button consistent with icon-button.