Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Deprecate Top App Bar renderProps #698

Closed
moog16 opened this issue Feb 27, 2019 · 5 comments
Closed

Deprecate Top App Bar renderProps #698

moog16 opened this issue Feb 27, 2019 · 5 comments
Labels
for-next

Comments

@moog16
Copy link

moog16 commented Feb 27, 2019

related #688

In v0.13.0 deprecate props and methods in top-app-bar/index.ts to support renderProps. This is in favor of compositional declaration of the TopAppBar.
@moog16 moog16 mentioned this issue Feb 27, 2019
Merged
3 tasks
@moog16 moog16 mentioned this issue Mar 27, 2019
Closed
@moog16
Copy link
Author

moog16 commented May 16, 2019

@mgr34 did you want to deprecate this since you also added the new top app bar format?

@mgr34
Copy link
Contributor

mgr34 commented May 20, 2019

hey @moog16 Sure, I will get to it sometime this week.

@moog16
Copy link
Author

moog16 commented May 20, 2019

awesome! Thanks

@mgr34
Copy link
Contributor

mgr34 commented May 24, 2019

Hey @moog16 I wont be able to get to it this week after all. I'll aim for sometime next week. Have a good holiday weekend.

@moog16
Copy link
Author

moog16 commented May 24, 2019 •
edited
Loading

no worries! we can push til next release. Have a great long weekend too! Thanks for getting back to me :)

@mgr34 mgr34 mentioned this issue Jun 6, 2019
Merged
@moog16 moog16 closed this as completed Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
for-next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moog16 @mgr34