Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

fix(tab): return ScrollContentWidth #633

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

seraph17
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@seraph17
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #633 into rc0.10.0 will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.10.0     #633      +/-   ##
============================================
- Coverage      94.9%   94.83%   -0.08%     
============================================
  Files            68       67       -1     
  Lines          2847     2768      -79     
  Branches        428      414      -14     
============================================
- Hits           2702     2625      -77     
  Misses           50       50              
+ Partials         95       93       -2
Impacted Files Coverage Δ
packages/tab-bar/index.tsx 85.71% <100%> (ø) ⬆️
packages/chips/Chip.tsx 97.77% <0%> (-0.21%) ⬇️
packages/chips/ChipSet.tsx 98.64% <0%> (-0.12%) ⬇️
packages/text-field/Input.tsx 96.72% <0%> (ø) ⬆️
packages/snackbar/index.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a376474...c68df5d. Read the comment docs.

@moog16 moog16 changed the base branch from master to rc0.10.0 January 24, 2019 17:25
@moog16
Copy link

moog16 commented Jan 24, 2019

@seraph17 - Wow can't believe our unit tests didn't catch this.

I just checked the tests and it is lacking. Could you add one? This is a probably causing issues, so I'd rather get this in than not. I can create an issue if you don't have the bandwidth.

@moog16
Copy link

moog16 commented Feb 12, 2019

#672 tests passing and signed cla in #633 (comment).

Opened issue #671 as TODO for a test.

Merging

@moog16 moog16 merged commit 7563dff into material-components:rc0.10.0 Feb 12, 2019
moog16 pushed a commit that referenced this pull request Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants