This repository was archived by the owner on Jan 14, 2025. It is now read-only.
(fix) Windows development #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc0.10.0 #662 +/- ##
========================================
Coverage 94.8% 94.8%
========================================
Files 68 68
Lines 2849 2849
Branches 429 429
========================================
Hits 2701 2701
Misses 51 51
Partials 97 97Continue to review full report at Codecov.
|
added 2 commits
February 7, 2019 14:13
This reverts commit d3b4b7a.
moog16
reviewed
Feb 7, 2019
|
I did not test the screenshots on Docker, the changes made were to get the
`npm run test:unit` to work first
I ran into other problems when trying to get this project setup on my
windows machine. `npm install/ci` is failing as well. I can log an issue
for that if you want.
…On Fri, 8 Feb 2019 at 07:11, Matt Goo ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for opening! Changes look good - I'll have to test myself on a
windows machine.
Did you also test the screenshot tests on Docker?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#662 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABFkvd5bnqBMaGAi--Qg8WUQpRiZnDIoks5vLJaBgaJpZM4amjJu>
.
|
|
gotcha - nope this is better than nothing :) |
|
tests pr #664 |
|
@madaz please sign this PR |
|
I signed it! |
moog16
approved these changes
Feb 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable development on windows environment.
Replace non-windows commands for npm cross environment packages.
rimrafreplaces thermcommandcross-envfor setting environment variables@moog16