Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

fix(chips): ChipSet no longer overwrites handle[Interaction|Select|Re… #651

Merged
merged 2 commits into from
Feb 6, 2019

Conversation

mgr34
Copy link
Contributor

@mgr34 mgr34 commented Jan 31, 2019

ChipSet was overwriting handle[Interaction|Select|Remove] of Chip. Therefore, functions passed were never called. Successful merging may close issue #650


I signed it

@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #651 into rc0.10.0 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc0.10.0     #651      +/-   ##
============================================
+ Coverage     94.87%   94.89%   +0.01%     
============================================
  Files            68       68              
  Lines          2831     2838       +7     
  Branches        426      426              
============================================
+ Hits           2686     2693       +7     
  Misses           50       50              
  Partials         95       95
Impacted Files Coverage Δ
packages/chips/ChipSet.tsx 98.76% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cf11cc...2fc7bb7. Read the comment docs.

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing that...I too was having issues with this, but didn't have the time to fix it. I just added tests so that this doesn't happen again. Please find them in this branch: mgr34-fix/chips/iss-650

@mgr34
Copy link
Contributor Author

mgr34 commented Feb 6, 2019

@moog16 thanks for the comments and the tests! I've merged them and pushed the additions :)

Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks again

@moog16 moog16 merged commit 9841e18 into material-components:rc0.10.0 Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants