Slm init #10
Closed
Slm init #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
…715) In addition to placing the double tests under aspect::fp64 checks, this commit accounts for the case where the compiler performs variadic argument promotion for the float type. Signed-off-by: Artem Gindinson <[email protected]>
Add a test that traces the PI calls and the Level Zero driver calls, and makes sure that the sequence of calls is consistent with the "static linking" implementation.
Add a test for the case when a kernel references an undefined symbol. We expect an exception at kernel submission time with a message telling the name of the undefined symbol.
Signed-off-by: Byoungro So <[email protected]>
…ess spaces (#570) Remove xfail from tests fixed by: intel/llvm#4966
This will be fixed in intel/llvm#5168
…t_t address spaces (#570)" (#724) This reverts commit 367e10e. Reverting due to intel/llvm#4966 revert.
* [SYCL][ESIMD] Add test for simd fill constructor The test currently verifies the basic types; it does not yet check types requiring checks "if supported on device", such as "sycl::half". Also, the test does not yet verify 32-element vectors due to existing runtime problems in either device drivers or ESIMD implementation.
…d unexpected behavior (#727)
Signed-off-by: Byoungro So <[email protected]>
The test is going to be disabled until intel/llvm#5282 is merged Signed-off-by: Sergey Kanaev <[email protected]>
Disabled test cases impacted by the fact that Clang and MSVC compilers have different behavior for sign bit of NAN/-NAN. Signed-off-by: jinge90 <[email protected]>
Previous fix removes substitution causing failure below: clang++: error: no such file or directory: '%fPIC'; did you mean '-fPIC'? The current fix provides substitution with empty string.
…iform way (#730) Signed-off-by: Sergey Dmitriev <[email protected]>
* [ESIMD] Enhance ext math test and cover sycl::half. Signed-off-by: Konstantin S Bobrovsky <[email protected]> Co-authored-by: Vyacheslav N Klochkov <[email protected]>
…ong event_t address spaces (#570)" (#724)" (#732) This reverts commit 0b6fc11. The failing test is fixed by intel/llvm#5293.
Improve pattern matchers: - SYCL **must be a directory** and **must be located in the root directory** Co-locate directory owned by the tools team and compiler tests.
Context variations are moved out as a test cases, with any action run directly over the simd move constructor result, with no further instance copy or move. XFAIL remains so if there is PR with move constructors added the CI will fail effectively specifying the need to change the tests The feature flag was hard-coded into the source to disable test freeze for any use case, with or without parsing the RUN directives Signed-off-by: Kochetkov, Yuriy <[email protected]>
Use GNU-style command line options to provide XPTI library on windows if clang++ is used.
Broadcast has recently been implemented for HIP backend in intel/llvm#5202 and XFAIL for AMD HIP was removed in #656. However on CI machines these tests are still failing, so we need to mark them XFAIL again
#984) Signed-off-by: Konstantin S Bobrovsky <[email protected]>
- fix BE selection for buffer tests - kernel execution parameter (global size, local size, offset) - kernel argument parameters (number, size, pointer which can be associated with accessor/USM buffer)
Signed-off-by: Arvind Sudarsanam <[email protected]>
…987) Co-authored-by: Byoungro So <[email protected]>
…em. Investigating this is a priority, but we need to disable tests to reduce false negative flags in other PRs. (#983) temporarily turning off three tests that seem to fail only on CI system. Investigating this is a priority, but we need to disable tests to reduce false negative flags in other PRs. Signed-off-by: Chris Perkins <[email protected]>
* [SYCL][ESIMD] Add test on simd select 2d function
ze_debug4 check is expected to fail for these tests because th L0 plugin doesn't take into account direct calls to L0 API.
* [SYCL][ESIMD] Make oword alignment usage explicit
Signed-off-by: Chris Perkins <[email protected]>
* Assign top level items uncovered by others to myself In theory this should never happen for this project since we contribute tests to SYCL dir only which is covered by @llvm-reviewers-runtime
Signed-off-by: Larsen, Steffen <[email protected]>
The optimization_level_debug_info test can on some systems cause a timeout due to the compilation time without optimizations and with debug symbols enabled. To avoid this timeout, this commit splits the test into two parts; one checking with integral optimization levels (e.g. -O2) and one checking with special-name optimization levels (e.g. -Og). Signed-off-by: Steffen Larsen <[email protected]>
Pairs with intel/llvm#6018 Signed-off-by: Chris Perkins [email protected]
If the test-suite was configured to pass -O0 the tests were changing their behavior because no dead kernel arguments optimization was performed, resulting in failing CHECKs. Be explicit in the "RUN:" commands and expected "CHECK:" lines.
…ime (#1003) The test is always in top 5 of longest CI tests. It consists of 2 subtests being compiled with different options and runnned separately. Splitted to 2 test without additional changes. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
…I time (#1004) The test is always in top 5 of longest CI tests exceeding recommended 20-30 seconds per test by running more than 50 seconds. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
…1008) Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Update latency control E2E tests to use property list in the API. The corresponding SYCL PR: intel/llvm#5993
This tests intel/llvm#6032. Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
ekilmer
added a commit
to trail-of-forks/instafix-llvm-test-suite
that referenced
this pull request
Jun 10, 2025
[6/7] : && /home/erickilmer/src/llvm-test-suite/build/tools/timeit --summary MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4.link.time /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld -O3 -DNDEBUG MultiSource/Benchmarks/tramp3d-v4/CMakeFiles/tramp3d-v4.dir/tramp3d-v4.cpp.o -o MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4 && cd /home/erickilmer/src/llvm-test-suite/build/MultiSource/Benchmarks/tramp3d-v4 && /usr/bin/cmake -E create_symlink /home/erickilmer/src/llvm-test-suite/MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4.reference_output /home/erickilmer/src/llvm-test-suite/build/MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4.reference_output FAILED: MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4 : && /home/erickilmer/src/llvm-test-suite/build/tools/timeit --summary MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4.link.time /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld -O3 -DNDEBUG MultiSource/Benchmarks/tramp3d-v4/CMakeFiles/tramp3d-v4.dir/tramp3d-v4.cpp.o -o MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4 && cd /home/erickilmer/src/llvm-test-suite/build/MultiSource/Benchmarks/tramp3d-v4 && /usr/bin/cmake -E create_symlink /home/erickilmer/src/llvm-test-suite/MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4.reference_output /home/erickilmer/src/llvm-test-suite/build/MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4.reference_output ClangLoc: /home/erickilmer/src/instafix-llvm/llvm/out/install/linux/bin/clang Executing a non indexed phase: "/home/erickilmer/src/instafix/out/build/linux/instafix-lld/instafix-lld-tool" -z relro --hash-style=gnu --eh-frame-hdr -m elf_x86_64 -pie -dynamic-linker /lib64/ld-linux-x86-64.so.2 -o MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4 /lib/x86_64-linux-gnu/Scrt1.o /lib/x86_64-linux-gnu/crti.o /usr/lib/gcc/x86_64-linux-gnu/13/crtbeginS.o -L/usr/lib/gcc/x86_64-linux-gnu/13 -L/usr/lib/gcc/x86_64-linux-gnu/13/../../../../lib64 -L/lib/x86_64-linux-gnu -L/lib/../lib64 -L/usr/lib/x86_64-linux-gnu -L/usr/lib64 -L/lib -L/usr/lib --fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld MultiSource/Benchmarks/tramp3d-v4/CMakeFiles/tramp3d-v4.dir/tramp3d-v4.cpp.o -lgcc --as-needed -lgcc_s --no-as-needed -lc -lgcc --as-needed -lgcc_s --no-as-needed /usr/lib/gcc/x86_64-linux-gnu/13/crtendS.o /lib/x86_64-linux-gnu/crtn.o program_name: /home/erickilmer/src/instafix/out/build/linux/instafix-lld/instafix-lld-tool input_file: /lib/x86_64-linux-gnu/Scrt1.o input_file: /lib/x86_64-linux-gnu/crti.o input_file: /usr/lib/gcc/x86_64-linux-gnu/13/crtbeginS.o input_file: MultiSource/Benchmarks/tramp3d-v4/CMakeFiles/tramp3d-v4.dir/tramp3d-v4.cpp.o input_file: /usr/lib/gcc/x86_64-linux-gnu/13/crtendS.o input_file: /lib/x86_64-linux-gnu/crtn.o instafix-lld-tool: /home/erickilmer/src/instafix-llvm/llvm/include/llvm/ADT/SmallVector.h:313: const_reference llvm::SmallVectorTemplateCommon<mlir::Operation *>::back() const [T = mlir::Operation *]: Assertion `!empty()' failed. could not parse main module PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace. Stack dump: 0. Program arguments: /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld -O3 -DNDEBUG MultiSource/Benchmarks/tramp3d-v4/CMakeFiles/tramp3d-v4.dir/tramp3d-v4.cpp.o -o MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4 #0 0x00005b86b8f13d41 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Unix/Signals.inc:804:11 #1 0x00005b86b8f1423b PrintStackTraceSignalHandler(void*) /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Unix/Signals.inc:880:1 #2 0x00005b86b8f119a6 llvm::sys::RunSignalHandlers() /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Signals.cpp:105:5 llvm#3 0x00005b86b8f14a1d SignalHandler(int, siginfo_t*, void*) /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Unix/Signals.inc:418:7 llvm#4 0x00007601f3845330 (/lib/x86_64-linux-gnu/libc.so.6+0x45330) llvm#5 0x00005b86abc1a58a mlir::Operation::getRegion(unsigned int) /home/erickilmer/src/instafix-llvm/llvm/out/install/linux/include/mlir/IR/Operation.h:688:5 llvm#6 0x00005b86ac94eb1f mlir::ModuleOp::getBodyRegion() /home/erickilmer/src/instafix-llvm/llvm/out/build/linux/tools/mlir/include/mlir/IR/BuiltinOps.h.inc:200:5 llvm#7 0x00005b86affa97b2 mlir::link::LinkState::LinkState(mlir::ModuleOp) /home/erickilmer/src/instafix-llvm/mlir/include/mlir/Linker/LinkerInterface.h:40:61 llvm#8 0x00005b86affa7108 mlir::link::Linker::link(bool) /home/erickilmer/src/instafix-llvm/mlir/lib/Linker/Linker.cpp:74:13 llvm#9 0x00005b86abbffd34 instafix::Loader::LinkInstafixLLVM() /home/erickilmer/src/instafix/instafix/lib/instafix.cpp:818:35 llvm#10 0x00005b86abc36dc2 instafix::LLDLoader::NativeLinkAndJIT(int, llvm::ArrayRef<char const*>, bool) /home/erickilmer/src/instafix/instafix/lib/LLDLoader.cpp:42:27 llvm#11 0x00005b86abbfa649 instafix::instafix_main(int, char**) /home/erickilmer/src/instafix/instafix/lib/instafix.cpp:264:32 llvm#12 0x00005b86abbf6992 main /home/erickilmer/src/instafix/bin/instafix-front/Main.cpp:25:3 llvm#13 0x00007601f382a1ca __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:74:3 llvm#14 0x00007601f382a28b call_init ./csu/../csu/libc-start.c:128:20 llvm#15 0x00007601f382a28b __libc_start_main ./csu/../csu/libc-start.c:347:5 llvm#16 0x00005b86abbf68a5 _start (/home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front+0x688a8a5)
ekilmer
added a commit
to trail-of-forks/instafix-llvm-test-suite
that referenced
this pull request
Jun 10, 2025
Just one example, but others are likely similar (at least with same
stacktrace)
```
[1/7] : && /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld -O3 -DNDEB
UG tools/CMakeFiles/not.dir/not.cpp.o -o tools/not && :
FAILED: tools/not
: && /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld -O3 -DNDEBUG tools/CMakeFiles/not.dir/not.cpp.o -o tools/not && :
ClangLoc: /home/erickilmer/src/instafix-llvm/llvm/out/install/linux/bin/clang
Executing a non indexed phase: "/home/erickilmer/src/instafix/out/build/linux/instafix-lld/instafix-lld-tool" -z relro --hash-style=gnu --eh-frame-hdr -m elf_x86_64 -pie -dynamic-linker /lib64/ld-linux-x86-64.so.2 -o tools/not /lib/x86_64-linux-gnu/Scrt1.o /lib/x86_64-linux-gnu/crti.o /usr/lib/gcc/x86_64-linux-gnu/13/crtbeginS.o -L/usr/lib/gcc/x86_64-linux-gnu/13 -L/usr/lib/gcc/x86_64-linux-gnu/13/../../../../lib64 -L/lib/x86_64-linux-gnu -L/lib/../lib64 -L/usr/lib/x86_64-linux-gnu -L/usr/lib64 -L/lib -L/usr/lib --fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld tools/CMakeFiles/not.dir/not.cpp.o -lgcc --as-needed -lgcc_s --no-as-needed -lc -lgcc --as-needed -lgcc_s --no-as-needed /usr/lib/gcc/x86_64-linux-gnu/13/crtendS.o /lib/x86_64-linux-gnu/crtn.o
program_name: /home/erickilmer/src/instafix/out/build/linux/instafix-lld/instafix-lld-tool
input_file: /lib/x86_64-linux-gnu/Scrt1.o
input_file: /lib/x86_64-linux-gnu/crti.o
input_file: /usr/lib/gcc/x86_64-linux-gnu/13/crtbeginS.o
input_file: tools/CMakeFiles/not.dir/not.cpp.o
input_file: /usr/lib/gcc/x86_64-linux-gnu/13/crtendS.o
input_file: /lib/x86_64-linux-gnu/crtn.o
loc("/lib/x86_64-linux-gnu/libc.so":1:1): error: unexpected character
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0. Program arguments: /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld -O3 -DNDEBUG tools/CMakeFiles/not.dir/not.cpp.o -o tools/not
#0 0x000064b890eb6d41 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Unix/Signals.inc:804:11
#1 0x000064b890eb723b PrintStackTraceSignalHandler(void*) /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Unix/Signals.inc:880:1
#2 0x000064b890eb49a6 llvm::sys::RunSignalHandlers() /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Signals.cpp:105:5
llvm#3 0x000064b890eb7a1d SignalHandler(int, siginfo_t*, void*) /home/erickilmer/src/instafix-llvm/llvm/lib/Support/Unix/Signals.inc:418:7
llvm#4 0x00007c3845445330 (/lib/x86_64-linux-gnu/libc.so.6+0x45330)
llvm#5 0x000064b883cd967c llvm::Value::getType() const /home/erickilmer/src/instafix-llvm/llvm/include/llvm/IR/Value.h:255:34
llvm#6 0x000064b88fc554d2 llvm::CastInst::castIsValid(llvm::Instruction::CastOps, llvm::Value*, llvm::Type*) /home/erickilmer/src/instafix-llvm/llvm/include/llvm/IR/InstrTypes.h:623:31
llvm#7 0x000064b890752419 llvm::ConstantExpr::getBitCast(llvm::Constant*, llvm::Type*, bool) /home/erickilmer/src/instafix-llvm/llvm/lib/IR/Constants.cpp:2325:3
llvm#8 0x000064b887051e16 mlir::LLVM::detail::getLLVMConstant(llvm::Type*, mlir::Attribute, mlir::Location, mlir::LLVM::ModuleTranslation const&) /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:602:5
llvm#9 0x000064b88705bb47 mlir::LLVM::ModuleTranslation::convertOneFunction(mlir::LLVM::LLVMFuncOp) /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:1465:25
llvm#10 0x000064b88705eea3 mlir::LLVM::ModuleTranslation::convertFunctions() /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:1804:16
llvm#11 0x000064b88706144d mlir::translateModuleToLLVMIR(mlir::Operation*, llvm::LLVMContext&, llvm::StringRef, bool) /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:2218:25
llvm#12 0x000064b883ba2fda instafix::Loader::LinkInstafixLLVM() /home/erickilmer/src/instafix/instafix/lib/instafix.cpp:837:7
llvm#13 0x000064b883bd9dc2 instafix::LLDLoader::NativeLinkAndJIT(int, llvm::ArrayRef<char const*>, bool) /home/erickilmer/src/instafix/instafix/lib/LLDLoader.cpp:42:27
llvm#14 0x000064b883b9d649 instafix::instafix_main(int, char**) /home/erickilmer/src/instafix/instafix/lib/instafix.cpp:264:32
llvm#15 0x000064b883b99992 main /home/erickilmer/src/instafix/bin/instafix-front/Main.cpp:25:3
llvm#16 0x00007c384542a1ca __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:74:3
llvm#17 0x00007c384542a28b call_init ./csu/../csu/libc-start.c:128:20
llvm#18 0x00007c384542a28b __libc_start_main ./csu/../csu/libc-start.c:347:5
llvm#19 0x000064b883b998a5 _start (/home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front+0x688a8a5)
Segmentation fault (core dumped)
```
with gdb stacktrace:
```
$ cd build
$ gdb --args /home/erickilmer/src/instafix/out/build/linux/bin/instafix-front/instafix-front --ld-path=instafix-lld-tool --for-linker=--fake-executable=/home/erickilmer/src/instafix/out/build/linux/bin/instafix-ld/instafix-ld -O3 -DNDEBUG tools/CMakeFiles/not.dir/not.cpp.o -o tools/not
[...]
(gdb) r
[...]
Thread 1 "instafix-front" received signal SIGSEGV, Segmentation fault.
llvm::Value::getType (this=0x0) at /home/erickilmer/src/instafix-llvm/llvm/include/llvm/IR/Value.h:255
255 Type *getType() const { return VTy; }
(gdb) bt
#0 llvm::Value::getType (this=0x0) at /home/erickilmer/src/instafix-llvm/llvm/include/llvm/IR/Value.h:255
#1 0x0000555567e9a4d2 in llvm::CastInst::castIsValid (op=llvm::Instruction::BitCast, S=0x0, DstTy=0x555569811470) at /home/erickilmer/src/instafix-llvm/llvm/include/llvm/IR/InstrTypes.h:623
#2 0x0000555568997419 in llvm::ConstantExpr::getBitCast (C=0x0, DstTy=0x555569811470, OnlyIfReduced=false) at /home/erickilmer/src/instafix-llvm/llvm/lib/IR/Constants.cpp:2325
llvm#3 0x000055555f296e16 in mlir::LLVM::detail::getLLVMConstant (llvmType=0x555569811470, attr=..., loc=..., moduleTranslation=...) at /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:602
llvm#4 0x000055555f2a0b47 in mlir::LLVM::ModuleTranslation::convertOneFunction (this=0x7fffffff3710, func=...) at /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:1465
llvm#5 0x000055555f2a3ea3 in mlir::LLVM::ModuleTranslation::convertFunctions (this=0x7fffffff3710) at /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:1804
llvm#6 0x000055555f2a644d in mlir::translateModuleToLLVMIR (module=0x5555697e32b0, llvmContext=..., name=..., disableVerification=false) at /home/erickilmer/src/instafix-llvm/mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:2218
llvm#7 0x000055555bde7fda in instafix::Loader::LinkInstafixLLVM (this=0x55556979ea80) at /home/erickilmer/src/instafix/instafix/lib/instafix.cpp:837
llvm#8 0x000055555be1edc2 in instafix::LLDLoader::NativeLinkAndJIT (this=0x55556979ea80, argc=7, argv=..., exec=false) at /home/erickilmer/src/instafix/instafix/lib/LLDLoader.cpp:42
llvm#9 0x000055555bde2649 in instafix::instafix_main (argc=8, argv=0x7fffffffccc8) at /home/erickilmer/src/instafix/instafix/lib/instafix.cpp:264
llvm#10 0x000055555bdde992 in main (argc=8, argv=0x7fffffffccc8) at /home/erickilmer/src/instafix/bin/instafix-front/Main.cpp:25
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.