Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] reenabling test in anticipation of GPU uplift #994

Merged
merged 2 commits into from
Apr 19, 2022
Merged

[SYCL] reenabling test in anticipation of GPU uplift #994

merged 2 commits into from
Apr 19, 2022

Conversation

cperkinsintel
Copy link

@cperkinsintel cperkinsintel commented Apr 18, 2022 •
edited
Loading

Pairs with intel/llvm#6018

Signed-off-by: Chris Perkins [email protected]

@cperkinsintel cperkinsintel requested a review from a team as a code owner April 18, 2022 18:54
@cperkinsintel cperkinsintel requested a review from againull April 18, 2022 18:54
This was referenced Apr 18, 2022
Merged
Merged
againull
againull previously approved these changes Apr 18, 2022
View reviewed changes
@cperkinsintel
Copy link
Author

/verify with intel/llvm#6018

@cperkinsintel
Copy link
Author

These tests are taking forever to run. The CI check named "Jenkins/pre-ci-linux" will likely fail, that is expected.
The CI check named "Jenkins/llvm-test-suite" is the one requested with the verify comment. If it passes (fingers crossed) then we should be good to go to merge this and then to merge the GPU uplift PR at intel/llvm#6018 and to close the outdated uplift attempt at intel/llvm#5995

This was referenced Apr 19, 2022
Merged
Closed
@cperkinsintel cperkinsintel requested a review from againull April 19, 2022 15:47
@cperkinsintel
Copy link
Author

ping to reviewers - this is ready to review and merge. As mentioned in the previous comment, the "Jenkins/pre-ci-linux" CI run is expected to fail and is irrelevant. The important part is that the "Jenkins/llvm-test-suite" run passed. Once this is merged we can then approve/merge the new GPU uplift (intel/llvm#6018) and close the outdated one ( intel/llvm#5995 )

@cperkinsintel
Copy link
Author

ping @againull or @pvchupin to merge this so we can get the 6018 uplift merged too and get closer to reliable testing.

@pvchupin pvchupin merged commit 1de20a0 into intel:intel Apr 19, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
@cperkinsintel @bb-sycl
[SYCL] reenabling test in anticipation of GPU uplift (intel#994)
5bbd9cb 
Pairs with intel/llvm#6018

Signed-off-by: Chris Perkins [email protected]
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@cperkinsintel
[SYCL] reenabling test in anticipation of GPU uplift (intel/llvm-test…
8be421f 
…-suite#994)

Pairs with intel#6018

Signed-off-by: Chris Perkins [email protected]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvchupin pvchupin Awaiting requested review from pvchupin

@againull againull Awaiting requested review from againull

1 more reviewer

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cperkinsintel @againull @steffenlarsen @pvchupin