Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Conversation

vasilytric
Copy link

No description provided.

Copy link

@yuriykoch yuriykoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to align the patch with functions_select_1d.hpp? Looks like it could be done by applying the comments from #875. I might easily miss something.

@vasilytric
Copy link
Author

@v-klochkov Would you mind to review this PR?

Copy link

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Can you please add one more separate test that would check zero and/or negative 'offset' and 'stride' cases?

@vasilytric
Copy link
Author

vasilytric commented Apr 1, 2022

Can you please add one more separate test that would check zero and/or negative 'offset' and 'stride' cases?

@v-klochkov Stride should be equal or greater than zero

include\sycl/ext/intel/esimd/detail/region.hpp:41:3: error: static_assert failed due to requirement 'Size_x > 0 && Stride_x >= 0' "illegal region in x-dimension"
  static_assert(Size_x > 0 && Stride_x >= 0, "illegal region in x-dimension");
  ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~

In case Offset is negative behavior is not clear (additional discussion is required) and I suggest to update coverage for simd 2d select in separate PR.
@v-klochkov what do you think about this?

@yuriykoch
Copy link

Can you please add one more separate test that would check zero and/or negative 'offset' and 'stride' cases?

One more point. Is it OK to have separate PR for this test? We would have tests from this PR in CI with no delay.

@kbobrovs kbobrovs merged commit afbdd0a into intel:intel Apr 13, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
* [SYCL][ESIMD] Add test on simd select 2d function
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…ite#908)

* [SYCL][ESIMD] Add test on simd select 2d function
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants