-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL][ESIMD] Add test on simd select 2d function #908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to align the patch with functions_select_1d.hpp
? Looks like it could be done by applying the comments from #875. I might easily miss something.
Because but we can't apply new value to all selected values
Add offset x and offset y
- Replace "indexess" with indexes - Replace "selected_indexses_ptr" with "next_selected_index"
They will verify correctness of chosen offsets
@v-klochkov Would you mind to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Can you please add one more separate test that would check zero and/or negative 'offset' and 'stride' cases?
@v-klochkov
In case |
One more point. Is it OK to have separate PR for this test? We would have tests from this PR in CI with no delay. |
* [SYCL][ESIMD] Add test on simd select 2d function
…ite#908) * [SYCL][ESIMD] Add test on simd select 2d function
No description provided.