[SYCL][HIP][libclc] Revert revert "Fix wrong address spaces for HIP" #5293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethandrews
approved these changes
Jan 12, 2022
smanna12
approved these changes
Jan 12, 2022
|
I forgot to link it when I opened this, but it needs to be run with tests from intel/llvm-test-suite#732. |
bader
approved these changes
Jan 13, 2022
bader
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Jan 13, 2022
…ong event_t address spaces (#570)" (#724)" (#732) This reverts commit 0b6fc11. The failing test is fixed by intel/llvm#5293.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ong event_t address spaces (intel/llvm-test-suite#570)" (intel/llvm-test-suite#724)" (intel/llvm-test-suite#732) This reverts commit 7883645. The failing test is fixed by intel#5293.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5284 , reintroducing the reverted #4966 and adds fixes the failing libclc test.