This repository was archived by the owner on Mar 28, 2023. It is now read-only.
temporary disable undefined-symbol test #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the GPU driver uplifted on GitHub Actions, this test both fails on GHA and passes on Jenkins, which is just confusing for everyone. Disabling temporarily. Signed-off-by: Chris Perkins <[email protected]>
againull
reviewed
Apr 22, 2022
| // because of problems getting GPU driver uplifted on GitHub Actions | ||
| // this test both fails on GHA and passes on Jenkins. | ||
| // Disabling it until this is sorted | ||
| // UNSUPPORTED: windows || linux |
There was a problem hiding this comment.
Probably it would be better to use // REQUIRES: TEMPORARILY_DISABLED, so that it is more clear that this test is temporarily disabled.
There was a problem hiding this comment.
Is that how we normally do it? That's a good BKM.
There was a problem hiding this comment.
Yes. It also allows to grep for TEMPORARILY_DISABLED and see our debts.
againull
approved these changes
Apr 24, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of problems getting the GPU driver uplifted on GitHub Actions, this test both fails on GHA and passes on Jenkins, which is just confusing for everyone. Disabling temporarily.
Signed-off-by: Chris Perkins [email protected]