Asyncify contract

[pacrob]

What was wrong?

Contracts getting asynced
Related to Issue #2270

How was it fixed?

All contract functions are asynced. ENS support will be added separately.

Todo:

• Add entry to the release notes

Cute Animal Picture

[dbfreem]

Something that the 2,359 line contract.py file got me thinking about was options for splitting it into a few different files. Splitting (if we decide to do so) would definitely be in another PR. This PR is big enough already :)

Off the top of my head, maybe the file tree looks something like:

- web3
    | contracts
        | __init__.py
        | _utils ? 
        | async_contract.py
        | base_contract.py
        | contract.py
    | eth
        | __init__.py
        | async_eth.py
        | base_eth.py
        ...

I totally agree with this approach. It will definitely help in visualizing the flow of the code.
For contract BaseContract, AsyncContract, Contract, Utils makes logical sense to me.

[kclowes]

This is looking good to me! I'm not sure how realistic this is, but before we merge, I'd like to try and have a more logical commit sequence. Let me know when you're done @pacrob and @dbfreem and I can look at that and decide if it's worth it or not.

[dbfreem]

I am all done @kclowes

[pacrob]

I'm done too @kclowes

[fselmo]

I made it through! 🎉 I left some pretty minor comments around DRY-ing things up, but I don't see any major architectural changes. @fselmo - will you also take a look when you get a chance?

Something that the 2,359 line contract.py file got me thinking about was options for splitting it into a few different files. Splitting (if we decide to do so) would definitely be in another PR. This PR is big enough already :)

Off the top of my head, maybe the file tree looks something like:

- web3
    | contracts
        | __init__.py
        | _utils ? 
        | async_contract.py
        | base_contract.py
        | contract.py
    | eth
        | __init__.py
        | async_eth.py
        | base_eth.py
        ...

but I'm open to feedback! And then if we split the contract classes, should we do the same for all Async Modules have their own files? 🤔 food for thought

I would definitely be on board with this 👍

[fselmo]

lgtm! 🚀

[fselmo]

closed by #2484 - created as a cleaned up commit history version of these same changes