Skip to content

Feature/asyncify contract #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Mar 15, 2022

Conversation

dbfreem
Copy link
Contributor

@dbfreem dbfreem commented Mar 15, 2022

asynced two more functions estimate_gas_for_function and transact_with_contract_function. Also, deprecated estimateGas for estimate_gas in ContractFunction. I took a note to add this in docs when we get to that point.

@dbfreem
Copy link
Contributor Author

dbfreem commented Mar 15, 2022

@pacrob Next I plan to work on build_transaction_for_function

@pacrob pacrob merged commit e30aa4e into ethereum:asyncify-contract Mar 15, 2022
@pacrob
Copy link
Contributor

pacrob commented Mar 16, 2022

Looking good! I'm still trying to sort out testing. Thank you!

pacrob pushed a commit to pacrob/web3.py that referenced this pull request Mar 31, 2022
* asyncify contract.transact and contract.estimate_gas
pacrob pushed a commit to pacrob/web3.py that referenced this pull request Apr 13, 2022
* asyncify contract.transact and contract.estimate_gas
pacrob pushed a commit to pacrob/web3.py that referenced this pull request Apr 23, 2022
* asyncify contract.transact and contract.estimate_gas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants