init commit of async contract

[dbfreem]

init commit of async contract see PR #2370

[dbfreem]

@pacrob Here is the AsyncEthereumTester and Contract parts of my other PR. I closed that PR.

One problem we will need to overcome with removing the ENS work is that contract is reliant on ENS there are other examples in there too. The problem I ran into while testing was that the w3 instance that is being used to create the AsyncContract has a AsyncEth Module in it. This web3 instance also has a standard ENS in it. When ens is called from AsyncContract the AsyncEth module is then used to call web3.eth.call which is async but ens is expecting it not to be async. Hope that all makes sense.

There may be a way around this like maybe not allowing ens addresses to be passed into AsyncContract until ENS is asyncified.

Thoughts??

Also, let me know what parts of async contract you want to work on and I can pick some of the left over parts.

Thanks, for setting this feature branch of for collaborating.

[dbfreem]

Just FYI, somewhere along the lines of moving the ENS out and fixing linting errors, a few of the test broke, Will look at these this evening as well as finish up the linting

[dbfreem]

I cleaned up some of the linting, and going to start on ContractEvents/ContractEvent

[pacrob]

I've been working on trying to resolve the linting but not much success today. Will continue tomorrow.

I think because this PR has the main class restructuring, we should get it in before I start changing anything further.

On the ENS dependency, is it just the calls to normalize_address that require the ENS object? If that's the only place, we could add a non-ens version of the normalizer or something similar.

[dbfreem]

So I almost have the Main BaseContract/Contract/AsyncContract done with the exception of a couple methods. I think it is just be the normalizer that was using ens so that's would probably work making a non ens version of it. I hope to finish that up later this evening or tommorrow.

The ENS part is isolated so you could probably work on the normalizer piece without conflicts until I finish the may contract object.

[pacrob]

Sounds good. I've added a normalize_address_no_ens function to the main feature branch.

[dbfreem]

Here is where I am at. I have that one weird lint error where it is complaining about the web3_module but besides that I "think" contract is for the "most part" done.

I pulled in your normalize_address_no_ens and used it in the AsyncContract

The next thing I was going to look at is ContractConstructor. It has some pieces that need to be async.

[pacrob]

Looks good. With that structure in, should be easier to work on in chunks.

I pulled it in with the lint failing, but it looks like reverting that ignore type line in web3/_utils/module_testing/web3_module.py fixes it. Is there another reason for removing it?

[dbfreem]

So one time I would run lint and it would tell me the typing wasn't right on that line and another time it would say that the type ignore was wrong. So probably just my local env being flaky. If removing the type ignore works then that is fine with me.