Feature/asyncify contract #2387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/asyncify_contract
… into feature/asyncify_contract
|
I plan to work on the |
|
Finished up |
|
Thanks! I'll be going through tests/core/contracts tests, figuring out what should be duplicated for async |
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Mar 31, 2022
* asyncify eth.contract * Contract build_transaction method
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Apr 13, 2022
* asyncify eth.contract * Contract build_transaction method
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Apr 23, 2022
* asyncify eth.contract * Contract build_transaction method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ContractConstructor I deprecated the buildTransacion since I had noticed that naming convention had been deprecated for a more pythonic naming convention in other parts of web3.py. I took a note to add this to the docs later when we do the docs updates
Finished up AsyncContractConstructor
Added a few new test