Cleaned up async contract PR #2484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ContractEvents/ContractEvent Async - fixed broken test - linting
This was referenced May 25, 2022
Closed
- setting default contract factory in AsyncEth to AsyncContract - estimateGas async in Contract and docs - build_transaction in ContractFunction - fill_transaction_defaults async for later use in build_transaction_for_function - async_parse_block_identifier_int - ContractConstructor - Create Base/Async structure for ContractFunctions, ContractEvents, Contract, ContractConstructor, ContractFunction, ContractEvent, ContractCaller classes - fixing combomethod for async support - fix test import in the wrong place - fixed the type in the cast of get_receive_function and get_fallback_function - rearranged BaseContractFunction.factory - removed async_fill_default from ethtester middleware - changed fill_transaction_defaults imports - fixed bug with async_call_contract_function - linting, linting, and more linting - docs
- Add newsfragment - Add missing awaits
- Remove un-needed chainId - Add missing await in async build_transaction, add chain_id to eth_tester middleware
[author credit given to original author, cleaned up by @fselmo]: After a large amount of cleaning up the commit history for ``asyncify-contract`` - squashing, removing merge commits from the commit history, rebasing with master - there was still a lot that wasn't picked up from ``asyncify-contract``. This commit was the process of performing a ``git diff {this branch} asyncify-contract`` and cleaning up the remaining differences until they were either just slightly refactored or there were no differences at all. Co-authored-by: pacrob <[email protected]>
fselmo
force-pushed
the
cleaned-up-async-contract
branch
from
751d7ae to
4541091
Compare
🎉 Thanks 
|
Wow! Awesome work everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Refer to PR #2441 as the main PR for these changes. This was the best attempt at squashing all those commits into a better / more useful commit history.
For reviewers:
Checking
git diff cleaned-up-async-contract asyncify-contractfor differences is a pretty easy approach to check the differences.closes #2441 #2270