Skip to content

Conversation

kuzm1ch
Copy link

@kuzm1ch kuzm1ch commented Feb 6, 2021

Description

  • avoid db_option_group creating in case DB engine is postgres
  • minor update example based on it

Motivation and Context

PostgreSQL does not use options and option groups. PostgreSQL uses extensions and modules to provide additional features. For more information, see Supported PostgreSQL features and extensions.

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_WorkingWithOptionGroups.html

Breaking Changes

In case "PostgresSQL option" was previosly created, it could some problem while removing it with next apply(cannot be deleted because it is in use).
terrafor state rm can be used as a workaround.

terraform state rm module.dbnew.module.db_option_group.aws_db_option_group.this

How Has This Been Tested?

examples/complete-postgres/main.tf

@kuzm1ch kuzm1ch force-pushed the fix/postgres_db_option branch from d91bfc0 to d8bd36e Compare February 6, 2021 13:49
@gschaffer-cxn
Copy link

gschaffer-cxn commented Feb 22, 2021

@antonbabenko can we get a review? This has been an issue and multiple PRs exist already:
#282
#259
#251
#188
#272

@bryantbiggs
Copy link
Member

I will take a look today and validate this change @kuzm1ch / @gschaffer-cxn

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants