Option Group gets created even if key is set to false

[chanster]

When setting creation of replica to false, the DB option group for replica still gets created.

tfvars

db_create = true
db_replica_create = false

tf

module "db" {
    source = "terraform-aws-modules/rds/aws"
    version= "~> 2.20"

    create_db_instance        = var.db_create
    create_db_option_group    = var.db_create
    create_db_parameter_group = var.db_create
    create_db_subnet_group    = var.db_create
    ...
}

module "db_replica" {
    source = "terraform-aws-modules/rds/aws"
    version= "~> 2.20"

    create_db_instance        = var.db_replica_create
    # replicas do not have these configurations
    create_db_option_group    = false
    create_db_parameter_group = false
    create_db_subnet_group    = false

    replicate_source_db = module.db.this_db_instance_id
    ...
}

TF output

module.db_replica.module.db_option_group.aws_db_option_group.this[0]: Creating...

[vojtapol]

Same issue here. I believe the problem is on this line:

enable_create_db_option_group = var.create_db_option_group ? true : var.option_group_name == "" && var.engine != "postgres"

it should be:

enable_create_db_option_group = var.create_db_option_group ? true : var.option_group_name != "" && var.engine != "postgres"

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.