Skip to content

fix: remove db_option_group for postgres engine, as not in use #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: remove db_option_group for postgres engine, as not in use #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions examples/complete-postgres/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ module "db" {
identifier = "demodb-postgres"

engine = "postgres"
engine_version = "9.6.9"
instance_class = "db.t2.large"
engine_version = "12.5"
instance_class = "db.t3.large"
allocated_storage = 5
storage_encrypted = false

Expand Down Expand Up @@ -62,10 +62,7 @@ module "db" {
subnet_ids = data.aws_subnet_ids.all.ids

# DB parameter group
family = "postgres9.6"

# DB option group
major_engine_version = "9.6"
family = "postgres12"

# Snapshot name upon DB deletion
final_snapshot_identifier = "demodb"
Expand Down
1 change: 0 additions & 1 deletion examples/replica-postgres/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ module "master" {
# DB subnet group
subnet_ids = data.aws_subnet_ids.all.ids

create_db_option_group = false
create_db_parameter_group = false
}

Expand Down
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ locals {
parameter_group_name_id = var.parameter_group_name != "" ? var.parameter_group_name : module.db_parameter_group.this_db_parameter_group_id

option_group_name = var.option_group_name != "" ? var.option_group_name : module.db_option_group.this_db_option_group_id
enable_create_db_option_group = var.create_db_option_group ? true : var.option_group_name == "" && var.engine != "postgres"
enable_create_db_option_group = var.create_db_option_group && var.engine != "postgres" ? true : var.option_group_name == "" && var.engine != "postgres"
}

module "db_subnet_group" {
Expand Down