Skip to content

Commit d8bd36e

Browse files
committed
fix: remove db_option_group for postgres engine, as not in use
and update examples based on it
1 parent c7bcd98 commit d8bd36e

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

examples/complete-postgres/main.tf

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ module "db" {
2727
identifier = "demodb-postgres"
2828

2929
engine = "postgres"
30-
engine_version = "9.6.9"
31-
instance_class = "db.t2.large"
30+
engine_version = "12.5"
31+
instance_class = "db.t3.large"
3232
allocated_storage = 5
3333
storage_encrypted = false
3434

@@ -62,10 +62,7 @@ module "db" {
6262
subnet_ids = data.aws_subnet_ids.all.ids
6363

6464
# DB parameter group
65-
family = "postgres9.6"
66-
67-
# DB option group
68-
major_engine_version = "9.6"
65+
family = "postgres12"
6966

7067
# Snapshot name upon DB deletion
7168
final_snapshot_identifier = "demodb"

examples/replica-postgres/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ module "master" {
5858
# DB subnet group
5959
subnet_ids = data.aws_subnet_ids.all.ids
6060

61-
create_db_option_group = false
6261
create_db_parameter_group = false
6362
}
6463

main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ locals {
55
parameter_group_name_id = var.parameter_group_name != "" ? var.parameter_group_name : module.db_parameter_group.this_db_parameter_group_id
66

77
option_group_name = var.option_group_name != "" ? var.option_group_name : module.db_option_group.this_db_option_group_id
8-
enable_create_db_option_group = var.create_db_option_group ? true : var.option_group_name == "" && var.engine != "postgres"
8+
enable_create_db_option_group = var.create_db_option_group && var.engine != "postgres" ? true : var.option_group_name == "" && var.engine != "postgres"
99
}
1010

1111
module "db_subnet_group" {

0 commit comments

Comments
 (0)