Migrate "Fork me" from ribbon to footer #2770
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @smarnach (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
see #2740 😉 |
In other footer links, only the first character is capitalized, for example “Send us an email”. This commit makes the “Getting Started” link consistent.
This commit removes the "Fork me on GitHub" ribbon and associated assets. This resolves the confusion whether "Fork me" refers to the crate itself, or to the crates.io site. A followup commit will migrate crates.io GitHub link to someplace less prominent.
A prior commit removed the "Fork me on GitHub" ribbon. This adds the link to the footer.
Turbo87
force-pushed
the
migrate-fork-me-to-footer
branch
from
9327f9e to
9921955
Compare
|
changed my mind. the redesign will still take quite a bit of time unfortunately, so I'll merge this as a good incremental improvement. thanks @ridiculousfish! (also, great user name and avatar! 😂) @bors r+ |
|
📌 Commit 9921955 has been approved by |
|
☀️ Test successful - checks-actions |
This moves the "Fork me on GitHub" link from a prominent corner ribbon to a footer link, and rewords it to "Fork crates.io on GitHub", removing the ambiguous "me". This is meant to address the confusion between accessing the source of a crate, and accessing the source of crates.io itself.
Without this change the source link for crates.io is much more prominent than the source link for the crate itself. Personally I've been bitten by this many times: I click on the ribbon intending to see the source for a crate. See #596 for some prior discussion.
To prevent the footer from becoming too crowded and wrapping, I removed the "Install" link, with the idea that "Getting Started" is sufficient. If you click "Getting Started" you quickly land on "Install" instructions.
The corner ribbon is gone. Footer before:
With this change: