Skip to content

Commit 272513f

Browse files
committed
Auto merge of #2770 - ridiculousfish:migrate-fork-me-to-footer, r=Turbo87
Migrate "Fork me" from ribbon to footer This moves the "Fork me on GitHub" link from a prominent corner ribbon to a footer link, and rewords it to "Fork crates.io on GitHub", removing the ambiguous "me". This is meant to address the confusion between accessing the source of a crate, and accessing the source of crates.io itself. Without this change the source link for crates.io is much more prominent than the source link for the crate itself. Personally I've been bitten by this many times: I click on the ribbon intending to see the source for a crate. See #596 for some prior discussion. To prevent the footer from becoming too crowded and wrapping, I removed the "Install" link, with the idea that "Getting Started" is sufficient. If you click "Getting Started" you quickly land on "Install" instructions. The corner ribbon is gone. Footer before: <img width="855" alt="Screen Shot 2020-09-10 at 7 55 34 PM" src="https://user-images.githubusercontent.com/920838/92849587-584d4f80-f3a0-11ea-9d1c-056fd3bad3a2.png"> With this change: <img width="855" alt="Screen Shot 2020-09-10 at 7 56 03 PM" src="https://user-images.githubusercontent.com/920838/92849607-5d120380-f3a0-11ea-84a6-ee15892b47cd.png">
2 parents 82cb342 + 9921955 commit 272513f

File tree

4 files changed

+5
-19
lines changed

4 files changed

+5
-19
lines changed

app/components/footer.hbs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
<footer local-class="footer">
22
<div local-class='after-main-links'>
3-
<a href='https://doc.rust-lang.org/cargo/getting-started/installation.html'>Install</a>
4-
<span local-class="sep">|</span>
5-
<a href='https://doc.rust-lang.org/cargo/'>Getting Started</a>
3+
<a href='https://doc.rust-lang.org/cargo/'>Getting started</a>
64
<span local-class="sep">|</span>
75
<a href='https://doc.rust-lang.org/cargo/guide/'>Guide</a>
86
<span local-class="sep">|</span>
97
<a href='mailto:[email protected]'>Send us an email</a>
108
<span local-class="sep">|</span>
119
<a href='https://www.rust-lang.org/policies/security'>Report a security issue</a>
1210
<span local-class="sep">|</span>
11+
<a href='https://github.com/rust-lang/crates.io'>Fork on GitHub</a>
12+
<span local-class="sep">|</span>
1313
<a href='https://www.rust-lang.org/policies/privacy'>Privacy notice</a>
1414
<span local-class="sep">|</span>
1515
<LinkTo @route="policies">Policies</LinkTo>
1616
</div>
17-
</footer>
17+
</footer>

app/components/footer.module.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
}
77

88
.sep {
9-
margin: 0 10px;
9+
margin: 0 5px;
1010
color: var(--separator-color);
1111
}
1212

app/styles/application.module.css

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -112,16 +112,6 @@ noscript {
112112
padding: 0 15px;
113113
}
114114

115-
.fork-me {
116-
position: absolute;
117-
top: 0;
118-
right: 0;
119-
120-
@media only screen and (max-width: 1180px) {
121-
display: none;
122-
}
123-
}
124-
125115
.toggle-design-button {
126116
position: fixed;
127117
bottom: 30px;

app/templates/application.hbs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@
1515

1616
<Footer/>
1717

18-
<a href='https://github.com/rust-lang/crates.io' local-class='fork-me'>
19-
<img src='/assets/forkme.png' alt="Fork me on GitHub">
20-
</a>
21-
2218
{{#if this.design.showToggleButton}}
2319
<button type="button" local-class="toggle-design-button" {{on "click" this.design.toggle}}>
2420
Toggle Design

0 commit comments

Comments
 (0)