Skip to content

Migrate "Fork me" from ribbon to footer #2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2020
Merged

Migrate "Fork me" from ribbon to footer #2770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
111fccd
Make “Getting Started” footer capitalization consistent
ridiculousfish Sep 10, 2020
3a90359
Remove the "Fork me on GitHub" ribbon
ridiculousfish Sep 10, 2020
9921955
Add "Fork on GitHub" to footer
ridiculousfish Sep 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/components/footer.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<footer local-class="footer">
<div local-class='after-main-links'>
<a href='https://doc.rust-lang.org/cargo/getting-started/installation.html'>Install</a>
<span local-class="sep">|</span>
<a href='https://doc.rust-lang.org/cargo/'>Getting Started</a>
<a href='https://doc.rust-lang.org/cargo/'>Getting started</a>
<span local-class="sep">|</span>
<a href='https://doc.rust-lang.org/cargo/guide/'>Guide</a>
<span local-class="sep">|</span>
<a href='mailto:[email protected]'>Send us an email</a>
<span local-class="sep">|</span>
<a href='https://www.rust-lang.org/policies/security'>Report a security issue</a>
<span local-class="sep">|</span>
<a href='https://github.com/rust-lang/crates.io'>Fork on GitHub</a>
<span local-class="sep">|</span>
<a href='https://www.rust-lang.org/policies/privacy'>Privacy notice</a>
<span local-class="sep">|</span>
<LinkTo @route="policies">Policies</LinkTo>
</div>
</footer>
</footer>
2 changes: 1 addition & 1 deletion app/components/footer.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
}

.sep {
margin: 0 10px;
margin: 0 5px;
color: var(--separator-color);
}

Expand Down
10 changes: 0 additions & 10 deletions app/styles/application.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,6 @@ noscript {
padding: 0 15px;
}

.fork-me {
position: absolute;
top: 0;
right: 0;

@media only screen and (max-width: 1180px) {
display: none;
}
}

.toggle-design-button {
position: fixed;
bottom: 30px;
Expand Down
4 changes: 0 additions & 4 deletions app/templates/application.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@

<Footer/>

<a href='https://github.com/rust-lang/crates.io' local-class='fork-me'>
<img src='/assets/forkme.png' alt="Fork me on GitHub">
</a>

{{#if this.design.showToggleButton}}
<button type="button" local-class="toggle-design-button" {{on "click" this.design.toggle}}>
Toggle Design
Expand Down