-
Notifications
You must be signed in to change notification settings - Fork 644
Make the "fork me on github" ribbon appear on narrower widths/zoomed in #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ah my browser windows are narrower than yours, and the ribbon disappears when the window is sufficiently thin. |
Whew, ok, I thought I was really losing it :) |
I think this raises a bigger issue. Many issues in the UI category make me wonder: why not redoing a design from scratch, using a mobile-first grid system (be it bootstrap, semantic ui, or anything else). There are many inconsistencies with the current design on narrow screens, but I don't think its worth pointing them out, I think a complete redesign would be easier to do than monkey-patching everywhere. If such a decision was taken, please count me in, I may be a bad Rust developper, but as far as front end design go, that's another story :p |
@Insomgla yes, there's actually a PR for a new design that's been outstanding, and another issue that links to other PRs. I know @aturon has thought about doing a redesign that unifies crates.io and rust-lang.org (which needs some Information Architecture work as well), but that's a bigger project that might need to go through the RFC process (or at least needs research with a variety of stakeholders). This is likely to be contentious with the community, and is tough to do incrementally. Would you be up for leading a design effort like that? |
I would 100% |
@Insomgla Could you send me an email please? [email protected]. Thanks! |
I personally think that the ribbon looks very out of place in crates.io, and an eventually design could provide better UI for both going to a crate's repository as well as contributing to crates.io itself. |
…bo87 Migrate "Fork me" from ribbon to footer This moves the "Fork me on GitHub" link from a prominent corner ribbon to a footer link, and rewords it to "Fork crates.io on GitHub", removing the ambiguous "me". This is meant to address the confusion between accessing the source of a crate, and accessing the source of crates.io itself. Without this change the source link for crates.io is much more prominent than the source link for the crate itself. Personally I've been bitten by this many times: I click on the ribbon intending to see the source for a crate. See #596 for some prior discussion. To prevent the footer from becoming too crowded and wrapping, I removed the "Install" link, with the idea that "Getting Started" is sufficient. If you click "Getting Started" you quickly land on "Install" instructions. The corner ribbon is gone. Footer before: <img width="855" alt="Screen Shot 2020-09-10 at 7 55 34 PM" src="https://user-images.githubusercontent.com/920838/92849587-584d4f80-f3a0-11ea-9d1c-056fd3bad3a2.png"> With this change: <img width="855" alt="Screen Shot 2020-09-10 at 7 56 03 PM" src="https://user-images.githubusercontent.com/920838/92849607-5d120380-f3a0-11ea-84a6-ee15892b47cd.png">
the ribbon has been converted to a link in the footer, so this issue no longer applies :) |
When I wanted to report an issue with the crates.io site, I didn't immediately know where to look.
It would be good if the site had one of those "fork me on github" ribbons; then someone could just click on that if they want to file an issue (or contribute!)
The text was updated successfully, but these errors were encountered: