Skip to content

Make the "fork me on github" ribbon appear on narrower widths/zoomed in #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pnkfelix opened this issue Mar 6, 2017 · 11 comments
Closed
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works E-help-wanted

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Mar 6, 2017

When I wanted to report an issue with the crates.io site, I didn't immediately know where to look.

It would be good if the site had one of those "fork me on github" ribbons; then someone could just click on that if they want to file an issue (or contribute!)

@carols10cents
Copy link
Member

. . . we have one of those though. . .

screen shot 2017-03-06 at 10 52 09 am

It's on individual crate pages too:

screen shot 2017-03-06 at 10 53 06 am

Is there a page that doesn't have this ribbon in the upper right?

@pnkfelix
Copy link
Member Author

pnkfelix commented Mar 6, 2017

ah my browser windows are narrower than yours, and the ribbon disappears when the window is sufficiently thin.

@pnkfelix
Copy link
Member Author

pnkfelix commented Mar 6, 2017

Example of "sufficiently thin":

image

@carols10cents
Copy link
Member

Whew, ok, I thought I was really losing it :)

@carols10cents carols10cents changed the title crates.io site should link to the github repo Make the "fork me on github" ribbon appear on narrower widths/zoomed in Mar 7, 2017
@ghost
Copy link

ghost commented Mar 8, 2017

I think this raises a bigger issue. Many issues in the UI category make me wonder: why not redoing a design from scratch, using a mobile-first grid system (be it bootstrap, semantic ui, or anything else).

There are many inconsistencies with the current design on narrow screens, but I don't think its worth pointing them out, I think a complete redesign would be easier to do than monkey-patching everywhere.

If such a decision was taken, please count me in, I may be a bad Rust developper, but as far as front end design go, that's another story :p

@carols10cents
Copy link
Member

@Insomgla yes, there's actually a PR for a new design that's been outstanding, and another issue that links to other PRs.

I know @aturon has thought about doing a redesign that unifies crates.io and rust-lang.org (which needs some Information Architecture work as well), but that's a bigger project that might need to go through the RFC process (or at least needs research with a variety of stakeholders). This is likely to be contentious with the community, and is tough to do incrementally.

Would you be up for leading a design effort like that?

@ghost
Copy link

ghost commented Mar 9, 2017

I would 100%

@carols10cents
Copy link
Member

@Insomgla Could you send me an email please? [email protected]. Thanks!

@carols10cents carols10cents added the C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works label Aug 2, 2017
@carols10cents carols10cents added this to the impl period milestone Sep 14, 2017
@carols10cents carols10cents removed this from the impl period milestone Sep 15, 2017
@ehuss
Copy link
Contributor

ehuss commented Jun 9, 2019

At certain widths, the "fork me" link overlaps with my username. Attempting to click on this region of my name takes me to GitHub.

image

Perhaps some z-index trickery or a non-rectangular click box could be used to avoid that.

@locks
Copy link
Contributor

locks commented Sep 7, 2019

I personally think that the ribbon looks very out of place in crates.io, and an eventually design could provide better UI for both going to a crate's repository as well as contributing to crates.io itself.

bors added a commit that referenced this issue Dec 6, 2020
…bo87

Migrate "Fork me" from ribbon to footer

This moves the "Fork me on GitHub" link from a prominent corner ribbon to a footer link, and rewords it to "Fork crates.io on GitHub", removing the ambiguous "me". This is meant to address the confusion between accessing the source of a crate, and accessing the source of crates.io itself.

Without this change the source link for crates.io is much more prominent than the source link for the crate itself. Personally I've been bitten by this many times: I click on the ribbon intending to see the source for a crate. See #596 for some prior discussion.

To prevent the footer from becoming too crowded and wrapping, I removed the "Install" link, with the idea that "Getting Started" is sufficient. If you click "Getting Started" you quickly land on "Install" instructions.

The corner ribbon is gone. Footer before:

<img width="855" alt="Screen Shot 2020-09-10 at 7 55 34 PM" src="https://user-images.githubusercontent.com/920838/92849587-584d4f80-f3a0-11ea-9d1c-056fd3bad3a2.png">

With this change:

<img width="855" alt="Screen Shot 2020-09-10 at 7 56 03 PM" src="https://user-images.githubusercontent.com/920838/92849607-5d120380-f3a0-11ea-84a6-ee15892b47cd.png">
@Turbo87
Copy link
Member

Turbo87 commented Feb 11, 2021

the ribbon has been converted to a link in the footer, so this issue no longer applies :)

@Turbo87 Turbo87 closed this as completed Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works E-help-wanted
Projects
None yet
Development

No branches or pull requests

5 participants