Skip to content

feat: completed the whatsnew section of the tutorial #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 5, 2020
Merged

Conversation

clacri
Copy link
Contributor

@clacri clacri commented May 3, 2020

He completado la sección what's now.

.gitignore Outdated
@@ -5,6 +5,9 @@
__pycache__/
*.py[cod]

# .mo files
*.mo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este está arriba, en la primera línea. No sé porqué no te los estaba detectando 🤷‍♂️

@raulcd raulcd self-requested a review May 3, 2020 11:15
Copy link
Collaborator

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creo que Claudia quería hacer unos cambios después de pasar pospell, verdad?

@clacri
Copy link
Contributor Author

clacri commented May 3, 2020

vale, si, queria hacer un par de cambios. Pero ahora me sale un conflicto. Me lo miro

"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Last-Translator: \n"
"Language-Team: \n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me parece que aquí va a diferir con el trabajo realizado en #41

Sería bueno hacer un script para actualizar antes de subir?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eamanu deberiamos tener un check que se fije que ese campo está actualizado o si podemos automatizar el cambio mejor. Queres armarte un issue y seguirlo?

@clacri cuando puedas por favor hacete un fix de esto (copiando lo que tienen los otros files) y ya podemos mergear este PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creo (espero) que ahora debería estar correcto :)

"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"Last-Translator: \n"
"Language-Team: \n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eamanu deberiamos tener un check que se fije que ese campo está actualizado o si podemos automatizar el cambio mejor. Queres armarte un issue y seguirlo?

@clacri cuando puedas por favor hacete un fix de esto (copiando lo que tienen los otros files) y ya podemos mergear este PR

@raulcd raulcd merged commit e244025 into 3.7 May 5, 2020
@raulcd raulcd deleted the claudia_dev_py37 branch May 5, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants