Skip to content

Conversation

@KonstantinTr
Copy link
Contributor

@KonstantinTr KonstantinTr commented Oct 23, 2017

  • Closes issue test_clearsky.test_simplified_solis_series_elevation is declared twice #387
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests must pass on the TravisCI and Appveyor testing services.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff and/or landscape.io linting service.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.

@wholmgren wholmgren changed the title Test clearsky.test simplified solis series elevation is declared twice fix test clearsky.test simplified solis series elevation is declared twice Oct 24, 2017
@wholmgren wholmgren merged commit cc380b1 into pvlib:master Oct 24, 2017
@wholmgren
Copy link
Member

thanks @KonstantinTr!

@wholmgren wholmgren added this to the 0.5.2 milestone Oct 24, 2017
@KonstantinTr KonstantinTr deleted the test_clearsky.test_simplified_solis_series_elevation-is-declared-twice branch October 26, 2017 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants