update from pvlib #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add draft i_from_v_alt function with tests * Better comments and more explicit typing * Use transform from shunt resistance to shunt conductance * Add v_from_i_alt() with initial tests and use np.where * Use test fixtures * Add @requires_scipy to test fixtures * More current_sum_at_diode_node() tests and using fixture * Naming, documentation, and formatting * Deprecate replaced functions and flake8 * Add release documentation and flake8 again * Replace deprecated function usages and update test_singlediode_series_ivcurve * Conform to existing API * Run flake8 * Implement some code quality suggestions * Remove extraneous print statements * Better docstrings * Fix parameter ranges in docstrings * Add test that overflows lambertw arg * Add test for mixed solution types logic * Use broadcast_arrays for cleaner code * One more simplification * Better use of broadcast_arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.