update from pvlib-python #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Fix bug in __repr__ method of ModelChain * Homogenize the string concatenation and the __repr__ method across the code. * Upate the test of ModelChain.__repr__ thanks to the code given by wholmgren in the comments discussing pull request #353 * Update the whatsnew/v0.4.6.rst file with the bug fix and the test update.
* changed np.nan to 0 in functions ashraeiam, physicaliam, sapm_aoi_loss * updated docstrings * updated tests to account for changes in functions * replace 0-degree aoi in physicaliam with 1e-06, analogous to the calculation of tau0 * updated tests to account for input angles of np.nan * updated test for ashraeiam to check for possible negative values for input angles close to 90° * updated docstring with info about nan-inputs resulting in nan. * updated variables-and-symbols-page with allowable range of aoi * changed whatsnew for v0.5 * applied @adriesse suggestion to split calculation of tau * forgot to delete unused line * typo :-( * typo in variables_styles_rules * implemented code suggestion by @adriesse
* Add analytical azimuth method. * Number linked references. * Add test for solar_azimuth_analytical. * Add an entry in the api.rst file. * Correct for different azimuth convention. * Update test tolerance. Not as accurate when azimuth angle is close to due north. * Added an entry in the v0.4.6 whatsnew file. * Update assert statements. * Update threshold for `atol=0.55` assert statement. * Update test, only when the sun is above horizon. Loops no longer needed.
…nce, fix ModelChain with SAT (#356) * add SingleAxisTracker.get_aoi, update ModelChain.prepare_inputs to use it * get tests to pass * update whatsnew * add test, clarify things * flake8
* change default modelchain orientation_strategy to None * add note to whatsnew
* add modelchain.ipynb using nbsphinx * fix code block overrun * update whatsnew * fix some references, minor edits
* add .github/PULL_REQUEST_TEMPLATE.md * update whatsnew, minor edit template * friendly pr template * add description request, delete request
* Improve convergence of lambertw for very large arguments * Revert "Improve convergence of lambertw for very large arguments" This reverts commit d83d77d. * Handle overflow warning; revise test case Handles overflow when apparent zenith is slight greater than 90. Revised test case to operate on zenith rather than time, removes dependence on solarposition. * Fix test case Resolve errors in test definition * more fixes Remove use of np.where in haurwitz, fix declaration of pandas objects * Fix pandas objects Changed np arrays from 2d to 1d for use as dataframe indices * more fixes Resolving type conflict inside haurwitz function for casting output as a dataframe * Final edits Fix line length, formatting and documentation in clearsky.haurwitz. Create whatsnew\v0.5.1.rst. Delete commented old code from test\test_clearsky.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.