update from pvlib #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix for issue #343 Now, passed 'offset' parameter are used instead of it's default value. * test for issue #343 * solar_position_method passed to basic_chain wasn't used causing execution of solarposition.get_solarposition with default 'nrel_numpy' value in all cases. * Update modelchain.py doc string fixes for modelchain.basic_chain function * Update v0.5.1.rst * Update v0.5.1.rst * Update v0.5.1.rst * According to 'Solar Position Algorithm for Solar Radiation Applications' by Ibrahim Reda and Afshin Andreas there is usage of alpha_prime. * what's new update for issue #366
* fix for issue #343 Now, passed 'offset' parameter are used instead of it's default value. * test for issue #343 * solar_position_method passed to basic_chain wasn't used causing execution of solarposition.get_solarposition with default 'nrel_numpy' value in all cases. * Update modelchain.py doc string fixes for modelchain.basic_chain function * Update v0.5.1.rst * Update v0.5.1.rst * Update v0.5.1.rst * altitude arg was missing. Consequentially, pressure was passed to altitude and temperature was passed to pressure. * Test for get_solarposition with method='pyephem' Should prevent args mismatch described in #374 This function is basically a copy of test_get_solarposition_no_kwargs modified to call get_solarposition with method='pyephem' * Update v0.5.1.rst * Now we pass keyword arguments instead of positional to be safe and consistent. * decorate test_get_solarposition_method_pyephem with @requires_ephem
* links corrected Fixes: #380 * updated whatnew
* add method to get_solar_position calls * update whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.