Remove Apache dependency to allow for higher Android target SDK. #554
Conversation
|
By analyzing the blame information on this pull request, we identified @grantland to be a potential reviewer. |
|
@Jawnnypoo updated the pull request - view changes |
|
@Jawnnypoo updated the pull request - view changes |
|
@Jawnnypoo updated the pull request - view changes |
|
Sorry for the spammy notifications, should be good to go now. Just had some strange Travis issues. |
|
Not really sure what I can do about the code coverage, this PR mostly just removes code, so I don't think it should be a concern |
|
Any thoughts on this @grantland ? |
Parse/build.gradle
Outdated
|
|
||
| testCompile 'org.robolectric:robolectric:3.0' | ||
| testCompile 'org.skyscreamer:jsonassert:1.2.3' | ||
| testCompile 'org.robolectric:robolectric:3.1.4' |
|
+1 okhttp is now the underlying interface of HttpUrlConnection. Can we get this merged in? |
|
Issue is related to: #231 |
|
Yeah I would love to see this moved forward. Supporting only one HttpClient should reduce the headache of supporting this SDK massively. |
|
I think @grantland is one of the only devs on this project that has the authority to merge PRs on this repo, but I don't think he is too active on doing so. |
|
@Jawnnypoo updated the pull request - view changes |
| NotificationCompat.Builder builder = new NotificationCompat.Builder(b.mContext); | ||
| builder.setContentTitle(b.mContentTitle); | ||
| builder.setContentText(b.mContentText); | ||
| builder.setContentIntent(b.mContentIntent); |
There was a problem hiding this comment.
is this going to work without running builder.build() and returning the result?
|
The rest of the PR (minus the notification stuff) looks great, thanks for doing this. Does anyone else have strong reservations/opinions about dropping the Apache client? Given Android 2.x is 1.0% of the market share (https://developer.android.com/about/dashboards/index.html), it seems like we should do this. We will bump to v1.14.XX once this happens. |
|
@Jawnnypoo updated the pull request - view changes |
|
@rogerhu This doesn't require dropping any support, we can continue to target 9 as the min version, using Okhttp exclusively does not change that number. 👍 |
|
Also, I fixed the Notification issue, so this should be good to go |
|
Thanks. I'm not seeing the latest build pushed up to Maven so going to check with Parse guys to figure out how to handle... :) |
|
@grantland on that point, could you let us on Sonatype or open a Pr for distribute on tags? |
|
I suspect that the builds are going up on Sonatype fine (https://books.sonatype.com/nexus-book/reference/staging-repositories.html) but need to be released either manually or via API |
commit aed49e2 Author: John <[email protected]> Date: Thu Mar 9 01:43:57 2017 -0600 Remove Apache dependency to allow for higher Android target SDK. (parse-community#554) * Remove Apache dependency to allow for higher Android target SDK. * Remove ParseURLConnectionHttpClient in favor of ParseOkHttpClient * Add JDK specification to Travis * Assure the latest tools are installed * Update to the latest dependencies * Update so that the notification is built properly commit 93dbb83 Author: Roger Hu <[email protected]> Date: Wed Mar 8 23:26:11 2017 -0800 Bump to 1.14.1 snapshot commit 5bacd08 Author: Roger Hu <[email protected]> Date: Wed Mar 8 17:36:50 2017 -0800 Bump to v1.13.3 release commit 735be49 Author: Mattia <[email protected]> Date: Thu Mar 9 02:34:25 2017 +0100 Closing streams in ParseAWSRequest (parse-community#590) * Update ParseAWSRequest.java commit 3fced98 Author: Florent Vilmart <[email protected]> Date: Wed Mar 8 20:33:32 2017 -0500 Create .codecov.yml (parse-community#594) commit ea489eb Merge: 5434260 b6c98bd Author: Roger Hu <[email protected]> Date: Wed Mar 8 12:15:29 2017 -0800 Merge pull request parse-community#592 from rogerhu/1.13.3 Bump to v1.13.3-SNAPSHOT commit b6c98bd Author: Roger Hu <[email protected]> Date: Wed Mar 8 12:14:17 2017 -0800 Bump to v1.13.3-SNAPSHOT commit 5434260 Merge: 64e74dc 2f2d856 Author: Roger Hu <[email protected]> Date: Wed Mar 8 12:10:59 2017 -0800 Merge pull request parse-community#591 from rogerhu/1.13.2 Bump to v1.13.2 release commit 2f2d856 Author: Roger Hu <[email protected]> Date: Wed Mar 8 12:08:55 2017 -0800 Bump to v1.13.2 release commit 64e74dc Merge: fe08345 f78a722 Author: Roger Hu <[email protected]> Date: Wed Mar 8 12:06:09 2017 -0800 Merge pull request parse-community#506 from posativ/patch-1 only add client key if non-null commit f78a722 Author: Martin Zimmermann <[email protected]> Date: Wed Jul 27 14:29:25 2016 +0200 only add client key if non-null
|
v13.3.3 is released thanks to @flovilmart. Apparently the release process is not quite automated on Travis yet but is being worked on. This PR has been merged into v1.14.1-snapshot. Would appreciate people check and see if there are any lingering issues. |
|
v1.14.0 is now out which should include these changes. |
|
Awesome! Thanks! |
This has a chance of resolving #551 though I cannot confirm as the message from Google is vague and does not point out what the issue is specifically. Reguardless, OkHttp 3.X is tried and true, and it seems like it would be a great replacement since the work is already done for it.
This is also a more complete PR of the work done in #418 without depending on beta versions of the SDK tools, plugin, etc.
The change in SDK version required a bump to Robolectric which is why a few of the tests changed as well.
I also added a nice Gradle plugin that allows you to check for the latest dependencies. I attempted to bring all dependencies up to date, but ran into complications with the latest versions of Mockito, so leaving a few of those for another PR.
Since this does drop an HTTP client implementation without deprecation, it may warrant a bump from 1.13.X to 1.14.X, but I leave that up to you. I just think if Google is truly blocking updates and app submissions based on Apache flaws (either coming from this library or otherwise) it is best to just leave it behind since it is deprecated in the SDK anyhow.