refactored to work on Android N #418
Conversation
|
By analyzing the blame information on this pull request, we identified @grantland, @wangmengyan95 and @Allsimon to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
@sudochownrwhoami updated the pull request. |
|
Hi facebook-github-bot, I signed up. That aside: I'm attempting to provide a working version of the Parse Android SDK specifically for the Android N Developer Preview The automated build failed because of the gradle version I am using that is apparently required for the Android N dev preview builds |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@sudochownrwhoami updated the pull request. |
|
It's awesome that you've looked into this! Is there a problem using the SDK on Android N or is this allowing the SDK to compile with Android N? We currently have an issue for getting the SDK to compile under Android M as it relies on APIs removed in M, but it works on M without any changes: #189 It seems like you've done the basic work outlined in that issue, however, your work will also break compatibility with < android-11 since Additionally, you can update |
|
@sudochownrwhoami updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Still waiting for working Travis-CI config |
ghost
added
the
| compile 'com.parse.bolts:bolts-tasks:1.4.0' | ||
|
|
||
| compile 'org.apache.httpcomponents:httpclient-android:4.3.5.1' |
There was a problem hiding this comment.
This is unnecessary since you already have useLibrary 'org.apache.http.legacy'
|
This should be updated to use non-beta versions of things like the compile SDK, build tools, etc. |
| @@ -9,20 +9,22 @@ version = '1.13.1-SNAPSHOT' | |||
| buildscript { | |||
| repositories { | |||
| mavenCentral() | |||
There was a problem hiding this comment.
you can kill this line, maven is redundant
| @@ -204,6 +214,6 @@ task jacocoTestReport(type:JacocoReport, dependsOn: "testDebugUnitTest") { | |||
|
|
|||
| //region Coveralls | |||
|
|
|||
| coveralls.jacocoReportPath = "${buildDir}/reports/jacoco/jacocoTestReport/jacocoTestReport.xml" | |||
| compile 'com.parse.bolts:bolts-tasks:1.4.0' | ||
|
|
||
| compile 'org.apache.httpcomponents:httpclient-android:4.3.5.1' | ||
| provided 'com.squareup.okhttp:okhttp:2.4.0' |
There was a problem hiding this comment.
these need to go to okhttp3
|
I think we need to get OkHttp3 stabilized with some of the more minor issues (i.e. v1.13.2 or v1.13.3) first -- waiting to hear back about the process to push to Sonatype/Maven, or if it's already automated if I push/tag a release. But let me look at that other PR.. |
|
Closing in lieu of #554 |
|
Sounds good. If nothing else, the library could be moved to a JitPack distribution since that requires no authentication to distribute so long as you can make tags in GitHub. |
No description provided.